From 3e293a9a2cdfbfe4fbbcaf993b4a368b278416b8 Mon Sep 17 00:00:00 2001
From: Vincenzo Scamporlino <vincenzos@spotify.com>
Date: Wed, 12 Apr 2023 18:30:03 +0200
Subject: [PATCH] scaffolder-backend: api report action rules

Signed-off-by: Vincenzo Scamporlino <vincenzos@spotify.com>
---
 plugins/scaffolder-backend/alpha-api-report.md | 16 ++++++++++++++--
 plugins/scaffolder-backend/api-report.md       | 14 +++++++-------
 2 files changed, 21 insertions(+), 9 deletions(-)

diff --git a/plugins/scaffolder-backend/alpha-api-report.md b/plugins/scaffolder-backend/alpha-api-report.md
index c59432a4ec..fe7ab73420 100644
--- a/plugins/scaffolder-backend/alpha-api-report.md
+++ b/plugins/scaffolder-backend/alpha-api-report.md
@@ -46,6 +46,18 @@ export const scaffolderActionConditions: Conditions<{
       actionId: string;
     }
   >;
+  hasBooleanProperty: PermissionRule<
+    {
+      action: string;
+      input: JsonObject | undefined;
+    },
+    {},
+    'scaffolder-action',
+    {
+      key: string;
+      value?: boolean | undefined;
+    }
+  >;
   hasNumberProperty: PermissionRule<
     {
       action: string;
@@ -54,8 +66,8 @@ export const scaffolderActionConditions: Conditions<{
     {},
     'scaffolder-action',
     {
-      value: number;
       key: string;
+      value?: number | undefined;
     }
   >;
   hasStringProperty: PermissionRule<
@@ -66,8 +78,8 @@ export const scaffolderActionConditions: Conditions<{
     {},
     'scaffolder-action',
     {
-      value: string;
       key: string;
+      value?: string | undefined;
     }
   >;
 }>;
diff --git a/plugins/scaffolder-backend/api-report.md b/plugins/scaffolder-backend/api-report.md
index 7e6050fe1d..5bcb38308b 100644
--- a/plugins/scaffolder-backend/api-report.md
+++ b/plugins/scaffolder-backend/api-report.md
@@ -273,7 +273,7 @@ export function createGithubRepoCreateAction(options: {
     requiredStatusCheckContexts?: string[] | undefined;
     requireBranchesToBeUpToDate?: boolean | undefined;
     requiredConversationResolution?: boolean | undefined;
-    repoVisibility?: 'public' | 'private' | 'internal' | undefined;
+    repoVisibility?: 'internal' | 'private' | 'public' | undefined;
     collaborators?:
       | (
           | {
@@ -388,7 +388,7 @@ export function createPublishBitbucketAction(options: {
     repoUrl: string;
     description?: string | undefined;
     defaultBranch?: string | undefined;
-    repoVisibility?: 'public' | 'private' | undefined;
+    repoVisibility?: 'private' | 'public' | undefined;
     sourcePath?: string | undefined;
     enableLFS?: boolean | undefined;
     token?: string | undefined;
@@ -408,7 +408,7 @@ export function createPublishBitbucketCloudAction(options: {
     repoUrl: string;
     description?: string | undefined;
     defaultBranch?: string | undefined;
-    repoVisibility?: 'public' | 'private' | undefined;
+    repoVisibility?: 'private' | 'public' | undefined;
     sourcePath?: string | undefined;
     token?: string | undefined;
   },
@@ -424,7 +424,7 @@ export function createPublishBitbucketServerAction(options: {
     repoUrl: string;
     description?: string | undefined;
     defaultBranch?: string | undefined;
-    repoVisibility?: 'public' | 'private' | undefined;
+    repoVisibility?: 'private' | 'public' | undefined;
     sourcePath?: string | undefined;
     enableLFS?: boolean | undefined;
     token?: string | undefined;
@@ -517,7 +517,7 @@ export function createPublishGithubAction(options: {
     requiredStatusCheckContexts?: string[] | undefined;
     requireBranchesToBeUpToDate?: boolean | undefined;
     requiredConversationResolution?: boolean | undefined;
-    repoVisibility?: 'public' | 'private' | 'internal' | undefined;
+    repoVisibility?: 'internal' | 'private' | 'public' | undefined;
     collaborators?:
       | (
           | {
@@ -571,7 +571,7 @@ export function createPublishGitlabAction(options: {
   {
     repoUrl: string;
     defaultBranch?: string | undefined;
-    repoVisibility?: 'public' | 'private' | 'internal' | undefined;
+    repoVisibility?: 'internal' | 'private' | 'public' | undefined;
     sourcePath?: string | undefined;
     token?: string | undefined;
     gitCommitMessage?: string | undefined;
@@ -595,7 +595,7 @@ export const createPublishGitlabMergeRequestAction: (options: {
     sourcePath?: string | undefined;
     targetPath?: string | undefined;
     token?: string | undefined;
-    commitAction?: 'create' | 'update' | 'delete' | undefined;
+    commitAction?: 'update' | 'delete' | 'create' | undefined;
     projectid?: string | undefined;
     removeSourceBranch?: boolean | undefined;
     assignee?: string | undefined;