From 3605370af64a3ddb82b5841e0cbc68f89c8c69d7 Mon Sep 17 00:00:00 2001 From: Larry Knott Date: Fri, 22 Sep 2023 16:09:09 -0600 Subject: [PATCH 1/2] Only show pagination controls when necessary Signed-off-by: Larry Knott --- .changeset/fuzzy-pillows-remain.md | 5 +++++ plugins/techdocs/src/home/components/Tables/DocsTable.tsx | 7 +++++-- 2 files changed, 10 insertions(+), 2 deletions(-) create mode 100644 .changeset/fuzzy-pillows-remain.md diff --git a/.changeset/fuzzy-pillows-remain.md b/.changeset/fuzzy-pillows-remain.md new file mode 100644 index 0000000000..d4fcb30415 --- /dev/null +++ b/.changeset/fuzzy-pillows-remain.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-techdocs': patch +--- + +Only show pagination controls when necessary diff --git a/plugins/techdocs/src/home/components/Tables/DocsTable.tsx b/plugins/techdocs/src/home/components/Tables/DocsTable.tsx index 5e5b41ee3e..927eaf7256 100644 --- a/plugins/techdocs/src/home/components/Tables/DocsTable.tsx +++ b/plugins/techdocs/src/home/components/Tables/DocsTable.tsx @@ -94,14 +94,17 @@ export const DocsTable = (props: DocsTableProps) => { actionFactories.createCopyDocsUrlAction(copyToClipboard), ]; + const pageSize = 20; + const paging = documents && documents.length > pageSize; + return ( <> {loading || (documents && documents.length > 0) ? ( isLoading={loading} options={{ - paging: true, - pageSize: 20, + paging, + pageSize, search: true, actionsColumnIndex: -1, ...options, From 01ed4782ac49fbad33bc574b34f0e30ab63f6e87 Mon Sep 17 00:00:00 2001 From: Larry Knott Date: Mon, 2 Oct 2023 12:37:51 -0700 Subject: [PATCH 2/2] Update Changeset to be more specific as suggested by @vinzscam Signed-off-by: Larry Knott --- .changeset/fuzzy-pillows-remain.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/fuzzy-pillows-remain.md b/.changeset/fuzzy-pillows-remain.md index d4fcb30415..59e3dd7896 100644 --- a/.changeset/fuzzy-pillows-remain.md +++ b/.changeset/fuzzy-pillows-remain.md @@ -2,4 +2,4 @@ '@backstage/plugin-techdocs': patch --- -Only show pagination controls when necessary +Improved `DocsTable` to display pagination controls dynamically, appearing only when needed.