diff --git a/plugins/scaffolder-backend/api-report.md b/plugins/scaffolder-backend/api-report.md index 0c01fd6a9e..8caa0ab0d4 100644 --- a/plugins/scaffolder-backend/api-report.md +++ b/plugins/scaffolder-backend/api-report.md @@ -572,8 +572,6 @@ export class TaskManager implements TaskContext_2 { // (undocumented) getWorkspaceName(): Promise; // (undocumented) - get isWorkspaceSerializationEnabled(): boolean; - // (undocumented) rehydrateWorkspace?(options: { taskId: string; targetPath: string; diff --git a/plugins/scaffolder-backend/src/scaffolder/tasks/StorageTaskBroker.ts b/plugins/scaffolder-backend/src/scaffolder/tasks/StorageTaskBroker.ts index 9f8f7df241..03a2833938 100644 --- a/plugins/scaffolder-backend/src/scaffolder/tasks/StorageTaskBroker.ts +++ b/plugins/scaffolder-backend/src/scaffolder/tasks/StorageTaskBroker.ts @@ -88,14 +88,6 @@ export class TaskManager implements TaskContext { private readonly config?: Config, ) {} - get isWorkspaceSerializationEnabled(): boolean { - return ( - this.config?.getOptionalBoolean( - 'scaffolder.EXPERIMENTAL_workspaceSerialization', - ) ?? false - ); - } - get spec() { return this.task.spec; } @@ -120,7 +112,7 @@ export class TaskManager implements TaskContext { taskId: string; targetPath: string; }): Promise { - if (this.isWorkspaceSerializationEnabled) { + if (this.isWorkspaceSerializationEnabled()) { this.storage.rehydrateWorkspace?.(options); } } @@ -171,7 +163,7 @@ export class TaskManager implements TaskContext { } async serializeWorkspace?(options: { path: string }): Promise { - if (this.isWorkspaceSerializationEnabled) { + if (this.isWorkspaceSerializationEnabled()) { await this.storage.serializeWorkspace?.({ path: options.path, taskId: this.task.taskId, @@ -180,7 +172,7 @@ export class TaskManager implements TaskContext { } async cleanWorkspace?(): Promise { - if (this.isWorkspaceSerializationEnabled) { + if (this.isWorkspaceSerializationEnabled()) { await this.storage.cleanWorkspace?.({ taskId: this.task.taskId }); } } @@ -219,6 +211,14 @@ export class TaskManager implements TaskContext { }, 1000); } + private isWorkspaceSerializationEnabled(): boolean { + return ( + this.config?.getOptionalBoolean( + 'scaffolder.EXPERIMENTAL_workspaceSerialization', + ) ?? false + ); + } + async getInitiatorCredentials(): Promise { const secrets = this.task.secrets as InternalTaskSecrets;