Fixed WelcomeTitle regression

Signed-off-by: Andre Wanlin <67169551+awanlin@users.noreply.github.com>
This commit is contained in:
Andre Wanlin
2023-01-25 12:40:19 -06:00
parent f36fd4b87c
commit 3d1d867d42
3 changed files with 36 additions and 3 deletions
+5
View File
@@ -0,0 +1,5 @@
---
'@backstage/plugin-home': patch
---
Fixed regresstion that caused the `WelcomeTitle` to not be the right size when passed to the `title` property of the `<Header>` component
@@ -0,0 +1,29 @@
/*
* Copyright 2023 The Backstage Authors
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import { Header } from '@backstage/core-components';
import { wrapInTestApp } from '@backstage/test-utils';
import React, { ComponentType } from 'react';
import { WelcomeTitle } from './WelcomeTitle';
export default {
title: 'Plugins/Home/Components/WelcomeTitle',
decorators: [(Story: ComponentType<{}>) => wrapInTestApp(<Story />)],
};
export const Default = () => {
return <Header title={<WelcomeTitle />} pageTitleOverride="Home" />;
};
@@ -19,7 +19,6 @@ import {
useApi,
} from '@backstage/core-plugin-api';
import { Tooltip } from '@material-ui/core';
import Typography from '@material-ui/core/Typography';
import React, { useEffect, useMemo } from 'react';
import useAsync from 'react-use/lib/useAsync';
import { getTimeBasedGreeting } from './timeUtil';
@@ -44,9 +43,9 @@ export const WelcomeTitle = () => {
return (
<Tooltip title={greeting.language}>
<Typography component="span">{`${greeting.greeting}${
<>{`${greeting.greeting}${
profile?.displayName ? `, ${profile?.displayName}` : ''
}!`}</Typography>
}!`}</>
</Tooltip>
);
};