paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 23 Packages Projects Releases Wiki Activity

Merge pull request #31246 from backstage/search-abortcontroller

Browse Source 
Implement AbortController request cancellation for search.
This commit is contained in:
Fredrik Adelöw
2025-10-07 23:02:12 +02:00
committed by GitHub
parent a4add851a4 482df90524
commit 3ce99627d0
17 changed files with 378 additions and 164 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/techdocs/src/search/components/TechDocsSearch.test.tsx
+56 -36
View File
@@ -84,16 +84,21 @@ it('should trigger query when autocomplete input changed', async () => {
);
await singleResult;
expect(querySpy).toHaveBeenCalledWith({
filters: {
kind: 'Testable',
name: 'test',
namespace: 'testspace',
expect(querySpy).toHaveBeenCalledWith(
{
filters: {
kind: 'Testable',
name: 'test',
namespace: 'testspace',
},
pageCursor: '',
term: '',
types: ['techdocs'],
},
pageCursor: '',
term: '',
types: ['techdocs'],
});
{
signal: expect.any(AbortSignal),
},
);
const autocomplete = screen.getByTestId('techdocs-search-bar');
const input = within(autocomplete).getByRole('textbox');
@@ -105,16 +110,21 @@ it('should trigger query when autocomplete input changed', async () => {
await singleResult;
await waitFor(() =>
expect(querySpy).toHaveBeenCalledWith({
filters: {
kind: 'Testable',
name: 'test',
namespace: 'testspace',
expect(querySpy).toHaveBeenCalledWith(
{
filters: {
kind: 'Testable',
name: 'test',
namespace: 'testspace',
},
pageCursor: '',
term: 'asdf',
types: ['techdocs'],
},
pageCursor: '',
term: 'asdf',
types: ['techdocs'],
}),
{
signal: expect.any(AbortSignal),
},
),
);
});
@@ -144,16 +154,21 @@ it('should update filter values when a new entityName is provided', async () =>
await renderInTestApp(<WrappedSearchBar />);
await singleResult;
expect(querySpy).toHaveBeenCalledWith({
filters: {
kind: 'Testable',
name: 'test',
namespace: 'testspace',
expect(querySpy).toHaveBeenCalledWith(
{
filters: {
kind: 'Testable',
name: 'test',
namespace: 'testspace',
},
pageCursor: '',
term: '',
types: ['techdocs'],
},
pageCursor: '',
term: '',
types: ['techdocs'],
});
{
signal: expect.any(AbortSignal),
},
);
const button = screen.getByText('Update Entity');
act(() => {
@@ -162,15 +177,20 @@ it('should update filter values when a new entityName is provided', async () =>
await singleResult;
await waitFor(() =>
expect(querySpy).toHaveBeenCalledWith({
filters: {
kind: 'TestableDiff',
name: 'test-diff',
namespace: 'testspace-diff',
expect(querySpy).toHaveBeenCalledWith(
{
filters: {
kind: 'TestableDiff',
name: 'test-diff',
namespace: 'testspace-diff',
},
pageCursor: '',
term: '',
types: ['techdocs'],
},
pageCursor: '',
term: '',
types: ['techdocs'],
}),
{
signal: expect.any(AbortSignal),
},
),
);
});