From 3c2ec77f8b747c303c882ee39371ebea705c553f Mon Sep 17 00:00:00 2001 From: Himanshu Mishra Date: Wed, 20 Jan 2021 18:04:42 +0100 Subject: [PATCH] backend: Azure URL Reader does not yet support file path based readTree --- packages/backend-common/src/reading/AzureUrlReader.ts | 2 ++ packages/backend-common/src/reading/BitbucketUrlReader.ts | 6 +----- packages/backend-common/src/reading/GitlabUrlReader.ts | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/packages/backend-common/src/reading/AzureUrlReader.ts b/packages/backend-common/src/reading/AzureUrlReader.ts index 59e437607f..578db2ac92 100644 --- a/packages/backend-common/src/reading/AzureUrlReader.ts +++ b/packages/backend-common/src/reading/AzureUrlReader.ts @@ -76,6 +76,8 @@ export class AzureUrlReader implements UrlReader { url: string, options?: ReadTreeOptions, ): Promise { + // TODO: Support filepath based reading tree feature like other providers + // Get latest commit SHA const commitsAzureResponse = await fetch( diff --git a/packages/backend-common/src/reading/BitbucketUrlReader.ts b/packages/backend-common/src/reading/BitbucketUrlReader.ts index 5b9dc7f333..e9727e04cf 100644 --- a/packages/backend-common/src/reading/BitbucketUrlReader.ts +++ b/packages/backend-common/src/reading/BitbucketUrlReader.ts @@ -101,17 +101,13 @@ export class BitbucketUrlReader implements UrlReader { url: string, options?: ReadTreeOptions, ): Promise { - const { name: repoName, owner: project, resource, filepath } = parseGitUrl( - url, - ); + const { filepath } = parseGitUrl(url); const lastCommitShortHash = await this.getLastCommitShortHash(url); if (options?.etag && options.etag === lastCommitShortHash) { throw new NotModifiedError(); } - const isHosted = resource === 'bitbucket.org'; - const downloadUrl = await getBitbucketDownloadUrl(url, this.config); const archiveBitbucketResponse = await fetch( downloadUrl, diff --git a/packages/backend-common/src/reading/GitlabUrlReader.ts b/packages/backend-common/src/reading/GitlabUrlReader.ts index 24fc640784..654f4f9a85 100644 --- a/packages/backend-common/src/reading/GitlabUrlReader.ts +++ b/packages/backend-common/src/reading/GitlabUrlReader.ts @@ -78,7 +78,7 @@ export class GitlabUrlReader implements UrlReader { url: string, options?: ReadTreeOptions, ): Promise { - const { name: repoName, ref, full_name, filepath } = parseGitUrl(url); + const { ref, full_name, filepath } = parseGitUrl(url); // Use GitLab API to get the default branch // encodeURIComponent is required for GitLab API