From 3bdbba8c00d7868fd779a30ae91c61f2821e3e0c Mon Sep 17 00:00:00 2001
From: aramissennyeydd <aramis.sennyey@doordash.com>
Date: Mon, 29 Sep 2025 10:53:23 -0400
Subject: [PATCH] fix api reports

Signed-off-by: aramissennyeydd <aramis.sennyey@doordash.com>
---
 .../src/wiring/BackendInitializer.ts                |  6 +++++-
 packages/backend-plugin-api/report.api.md           | 10 ++++++----
 .../services/definitions/InstanceMetadataService.ts | 13 ++++---------
 .../backend-test-utils/src/services/mockServices.ts |  2 +-
 packages/backend/src/instanceMetadata.ts            |  4 ++--
 5 files changed, 18 insertions(+), 17 deletions(-)

diff --git a/packages/backend-app-api/src/wiring/BackendInitializer.ts b/packages/backend-app-api/src/wiring/BackendInitializer.ts
index 080f6c7c69..cf27f4dff9 100644
--- a/packages/backend-app-api/src/wiring/BackendInitializer.ts
+++ b/packages/backend-app-api/src/wiring/BackendInitializer.ts
@@ -122,7 +122,11 @@ function createInstanceMetadataServiceFactory(
               modules: [],
             };
           }
-          installedPlugins[feature.pluginId].modules.push({
+          (
+            installedPlugins[feature.pluginId].modules as Array<{
+              moduleId: string;
+            }>
+          ).push({
             moduleId: feature.moduleId,
           });
         }
diff --git a/packages/backend-plugin-api/report.api.md b/packages/backend-plugin-api/report.api.md
index ebc544deed..fdb30434ed 100644
--- a/packages/backend-plugin-api/report.api.md
+++ b/packages/backend-plugin-api/report.api.md
@@ -424,17 +424,19 @@ export interface HttpRouterServiceAuthPolicy {
 // @public (undocumented)
 export interface InstanceMetadataService {
   // (undocumented)
-  getInstalledPlugins: () => readonly InstanceMetadataServicePluginInfo[];
+  getInstalledPlugins: () => Promise<
+    ReadonlyArray<InstanceMetadataServicePluginInfo>
+  >;
 }
 
 // @public (undocumented)
 export interface InstanceMetadataServicePluginInfo {
   // (undocumented)
-  modules: {
+  readonly modules: ReadonlyArray<{
     moduleId: string;
-  }[];
+  }>;
   // (undocumented)
-  pluginId: string;
+  readonly pluginId: string;
 }
 
 export { isChildPath };
diff --git a/packages/backend-plugin-api/src/services/definitions/InstanceMetadataService.ts b/packages/backend-plugin-api/src/services/definitions/InstanceMetadataService.ts
index 7e3b3b03d1..49c4dfe765 100644
--- a/packages/backend-plugin-api/src/services/definitions/InstanceMetadataService.ts
+++ b/packages/backend-plugin-api/src/services/definitions/InstanceMetadataService.ts
@@ -16,20 +16,15 @@
 
 /** @public */
 export interface InstanceMetadataServicePluginInfo {
-  pluginId: string;
-  modules: {
+  readonly pluginId: string;
+  readonly modules: ReadonlyArray<{
     moduleId: string;
-  }[];
+  }>;
 }
 
-/** @internal */
-export type DeepReadonly<T> = {
-  readonly [K in keyof T]: T[K] extends object ? DeepReadonly<T[K]> : T[K];
-};
-
 /** @public */
 export interface InstanceMetadataService {
   getInstalledPlugins: () => Promise<
-    ReadonlyArray<DeepReadonly<InstanceMetadataServicePluginInfo>>
+    ReadonlyArray<InstanceMetadataServicePluginInfo>
   >;
 }
diff --git a/packages/backend-test-utils/src/services/mockServices.ts b/packages/backend-test-utils/src/services/mockServices.ts
index bdf55930dd..2782724d11 100644
--- a/packages/backend-test-utils/src/services/mockServices.ts
+++ b/packages/backend-test-utils/src/services/mockServices.ts
@@ -560,7 +560,7 @@ export namespace mockServices {
 
   export function instanceMetadata(): InstanceMetadataService {
     return {
-      getInstalledPlugins: () => [],
+      getInstalledPlugins: () => Promise.resolve([]),
     };
   }
   export namespace instanceMetadata {
diff --git a/packages/backend/src/instanceMetadata.ts b/packages/backend/src/instanceMetadata.ts
index 463b2c317d..4f12fc889d 100644
--- a/packages/backend/src/instanceMetadata.ts
+++ b/packages/backend/src/instanceMetadata.ts
@@ -28,9 +28,9 @@ export default createBackendPlugin({
         logger: coreServices.logger,
       },
       async init({ instanceMetadata, logger }) {
+        const plugins = await instanceMetadata.getInstalledPlugins();
         logger.info(
-          `Installed plugins on this instance: ${instanceMetadata
-            .getInstalledPlugins()
+          `Installed plugins on this instance: ${plugins
             .map(e => e.pluginId)
             .join(', ')}`,
         );