From 3bd2518f1ffac89ca3790adf62716e295b4b3ce6 Mon Sep 17 00:00:00 2001 From: Jen Evans Date: Fri, 12 May 2023 10:51:38 -0700 Subject: [PATCH] Orphan cleanup - only log if entities were deleted Signed-off-by: Jen Evans --- .changeset/friendly-frogs-drop.md | 2 +- .../src/processing/DefaultCatalogProcessingEngine.ts | 4 +++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.changeset/friendly-frogs-drop.md b/.changeset/friendly-frogs-drop.md index a338bb3a7c..682f1dbabb 100644 --- a/.changeset/friendly-frogs-drop.md +++ b/.changeset/friendly-frogs-drop.md @@ -2,4 +2,4 @@ '@backstage/plugin-catalog-backend': patch --- -Change orphan cleanup task to debug log from info. +Change orphan cleanup task to only log a message if it deleted entities. diff --git a/plugins/catalog-backend/src/processing/DefaultCatalogProcessingEngine.ts b/plugins/catalog-backend/src/processing/DefaultCatalogProcessingEngine.ts index c24698f7e9..8e2f8b2f6f 100644 --- a/plugins/catalog-backend/src/processing/DefaultCatalogProcessingEngine.ts +++ b/plugins/catalog-backend/src/processing/DefaultCatalogProcessingEngine.ts @@ -317,7 +317,9 @@ export class DefaultCatalogProcessingEngine implements CatalogProcessingEngine { try { await this.processingDatabase.transaction(async tx => { const n = await this.processingDatabase.deleteOrphanedEntities(tx); - this.logger.debug(`Deleted ${n} orphaned entities`); + if (n > 0) { + this.logger.info(`Deleted ${n} orphaned entities`); + } }); } catch (error) { this.logger.warn(`Failed to delete orphaned entities`, error);