From 3b527b7ae6a0385de4acd0a217f6d2f3eda0e64c Mon Sep 17 00:00:00 2001 From: Alex Eftimie Date: Wed, 9 Oct 2024 05:33:38 +0200 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Alex Lorenzi <671432+alexlorenzi@users.noreply.github.com> Signed-off-by: Alex Eftimie --- .../src/collators/DefaultTechDocsCollatorFactory.ts | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/plugins/search-backend-module-techdocs/src/collators/DefaultTechDocsCollatorFactory.ts b/plugins/search-backend-module-techdocs/src/collators/DefaultTechDocsCollatorFactory.ts index 4e4b1417cd..0b53b33b30 100644 --- a/plugins/search-backend-module-techdocs/src/collators/DefaultTechDocsCollatorFactory.ts +++ b/plugins/search-backend-module-techdocs/src/collators/DefaultTechDocsCollatorFactory.ts @@ -109,10 +109,8 @@ export class DefaultTechDocsCollatorFactory implements DocumentCollatorFactory { new CatalogClient({ discoveryApi: options.discovery }); this.parallelismLimit = options.parallelismLimit ?? 10; this.legacyPathCasing = options.legacyPathCasing ?? false; - // @ts-ignore - this.entityTransformer = options.entityTransformer ?? (() => {}); - // @ts-ignore - this.documentTransformer = options.documentTransformer ?? (() => {}); + this.entityTransformer = options.entityTransformer ?? (() => ({})); + this.documentTransformer = options.documentTransformer ?? (() => ({})); this.auth = createLegacyAuthAdapters({ auth: options.auth, @@ -228,8 +226,8 @@ export class DefaultTechDocsCollatorFactory implements DocumentCollatorFactory { return searchIndex.docs.map((doc: MkSearchIndexDoc) => ({ ...defaultTechDocsCollatorEntityTransformer(entity), ...defaultTechDocsCollatorDocumentTransformer(doc), - ...(this.entityTransformer(entity) ?? {}), - ...(this.documentTransformer(doc) ?? {}), + ...this.entityTransformer(entity), + ...this.documentTransformer(doc), location: this.applyArgsToFormat( this.locationTemplate || '/docs/:namespace/:kind/:name/:path', {