From 39ab9a4150d0a27d19879b6a0395190beae9b8f7 Mon Sep 17 00:00:00 2001 From: Nicolas Torres Date: Tue, 27 Jul 2021 11:24:28 +0200 Subject: [PATCH] Updates changeset and adds EntityProcessingErrorsPanel to entitypage Signed-off-by: Nicolas Torres --- .changeset/tricky-trains-change.md | 29 +++++++++++++++---- .../app/src/components/catalog/EntityPage.tsx | 9 +++--- plugins/catalog/api-report.md | 2 +- 3 files changed, 30 insertions(+), 10 deletions(-) diff --git a/.changeset/tricky-trains-change.md b/.changeset/tricky-trains-change.md index 95fa8e3398..391dee0eb1 100644 --- a/.changeset/tricky-trains-change.md +++ b/.changeset/tricky-trains-change.md @@ -1,8 +1,27 @@ --- -'example-app': minor -'@backstage/core-components': minor -'@backstage/plugin-catalog': minor +'@backstage/core-components': patch +'@backstage/plugin-catalog': patch --- -Displays errors in the entity page if the entity yaml is malformed -WarningPanel changes color depending on the severity +Added an EntityProcessingErrorsPanel component to show any errors that occurred when refreshing an entity from its source location. If upgrading, this should be added to EntityPage in your Backstage application: + +```diff +// packages/app/src/components/catalog/EntityPage.tsx + +const overviewContent = ( +... + + + + ++ ++ ++ ++ ++ ++ ++ + +``` + +Additionally, WarningPanel now changes color based on the provided severity. diff --git a/packages/app/src/components/catalog/EntityPage.tsx b/packages/app/src/components/catalog/EntityPage.tsx index a793c20b86..d84a7341bc 100644 --- a/packages/app/src/components/catalog/EntityPage.tsx +++ b/packages/app/src/components/catalog/EntityPage.tsx @@ -40,8 +40,8 @@ import { isKind, EntityHasResourcesCard, EntityOrphanWarning, - EntityProcessErrors, - hasErrors, + EntityProcessingErrorsPanel, + hasCatalogProcessingErrors, isOrphan, } from '@backstage/plugin-catalog'; import { @@ -232,10 +232,11 @@ const overviewContent = ( + - + - + diff --git a/plugins/catalog/api-report.md b/plugins/catalog/api-report.md index 9deda407d7..b7aece991b 100644 --- a/plugins/catalog/api-report.md +++ b/plugins/catalog/api-report.md @@ -366,7 +366,7 @@ export const FilteredEntityLayout: ({ // Warning: (ae-missing-release-tag) "hasErrors" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) // // @public (undocumented) -export const hasErrors: (entity: Entity) => boolean; +export const hasCatalogProcessingErrors: (entity: Entity) => boolean; // Warning: (ae-missing-release-tag) "isComponentType" is exported by the package, but it is missing a release tag (@alpha, @beta, @public, or @internal) //