Review feedback 2: electric boogaloo

Co-authored-by: Otto Sichert <git@ottosichert.de>
Co-authored-by: Anders Näsman <realandersn@users.noreply.github.com>
Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
This commit is contained in:
Eric Peterson
2022-04-12 15:13:04 +02:00
parent a357c354af
commit 39a6eda01d
24 changed files with 271 additions and 245 deletions
+2 -2
View File
@@ -19,7 +19,6 @@ import { NotFoundError } from '@backstage/errors';
import React from 'react';
import { CompoundEntityRef } from '@backstage/catalog-model';
import {
TechDocsReaderPageProvider,
TechDocsReaderPageContent,
SyncResult,
TechDocsStorageApi,
@@ -31,6 +30,7 @@ import {
discoveryApiRef,
identityApiRef,
} from '@backstage/core-plugin-api';
import { TechDocsReaderPageProvider } from '@backstage/plugin-techdocs-react';
import { Header, Page, TabbedLayout } from '@backstage/core-components';
// used so each route can provide it's own implementation in the constructor of the react component
@@ -114,7 +114,7 @@ function createPage({
render() {
return (
<TechDocsReaderPageProvider
entityName={{
entityRef={{
kind: 'Component',
namespace: 'default',
name: 'my-docs',