diff --git a/.changeset/good-sloths-pretend.md b/.changeset/good-sloths-pretend.md new file mode 100644 index 0000000000..a0d8859707 --- /dev/null +++ b/.changeset/good-sloths-pretend.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +Enhance the sidebar item accessibility by using appropriate header semantics. diff --git a/.changeset/two-cobras-shake.md b/.changeset/two-cobras-shake.md new file mode 100644 index 0000000000..173d68e626 --- /dev/null +++ b/.changeset/two-cobras-shake.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-explore': patch +--- + +Enhance the tools card accessibility by using appropriate header semantics. diff --git a/packages/core-components/src/layout/Sidebar/Items.tsx b/packages/core-components/src/layout/Sidebar/Items.tsx index 924182086f..715e0d4af7 100644 --- a/packages/core-components/src/layout/Sidebar/Items.tsx +++ b/packages/core-components/src/layout/Sidebar/Items.tsx @@ -411,7 +411,11 @@ const SidebarItemBase = forwardRef((props, ref) => { {itemIcon} {text && ( - + {text} )} diff --git a/packages/core-components/src/layout/Sidebar/SidebarSubmenu.tsx b/packages/core-components/src/layout/Sidebar/SidebarSubmenu.tsx index 949148d7a1..85ba923672 100644 --- a/packages/core-components/src/layout/Sidebar/SidebarSubmenu.tsx +++ b/packages/core-components/src/layout/Sidebar/SidebarSubmenu.tsx @@ -127,7 +127,7 @@ export const SidebarSubmenu = (props: SidebarSubmenuProps) => { [classes.drawerOpen]: isSubmenuOpen, })} > - + {props.title} {props.children} diff --git a/packages/core-components/src/layout/Sidebar/SidebarSubmenuItem.tsx b/packages/core-components/src/layout/Sidebar/SidebarSubmenuItem.tsx index d05ee23636..d1925036bb 100644 --- a/packages/core-components/src/layout/Sidebar/SidebarSubmenuItem.tsx +++ b/packages/core-components/src/layout/Sidebar/SidebarSubmenuItem.tsx @@ -172,11 +172,19 @@ export const SidebarSubmenuItem = (props: SidebarSubmenuItemProps) => { )} > {Icon && } - + {title}
{subtitle && ( - + {subtitle} )} @@ -204,7 +212,7 @@ export const SidebarSubmenuItem = (props: SidebarSubmenuItemProps) => { onClick={closeSubmenu} onTouchStart={e => e.stopPropagation()} > - + {object.title} @@ -230,11 +238,19 @@ export const SidebarSubmenuItem = (props: SidebarSubmenuItemProps) => { onTouchStart={e => e.stopPropagation()} > {Icon && } - + {title}
{subtitle && ( - + {subtitle} )} diff --git a/plugins/explore/src/components/ToolCard/ToolCard.test.tsx b/plugins/explore/src/components/ToolCard/ToolCard.test.tsx index a216f65c5d..20bf6bb594 100644 --- a/plugins/explore/src/components/ToolCard/ToolCard.test.tsx +++ b/plugins/explore/src/components/ToolCard/ToolCard.test.tsx @@ -36,8 +36,12 @@ describe('', () => { }); it('renders props correctly', () => { - const { getByText } = render(wrapInTestApp()); - expect(getByText(minProps.card.title)).toBeInTheDocument(); + const { getByRole, getByText } = render( + wrapInTestApp(), + ); + expect( + getByRole('heading', { name: minProps.card.title }), + ).toBeInTheDocument(); expect(getByText(minProps.card.description)).toBeInTheDocument(); }); diff --git a/plugins/explore/src/components/ToolCard/ToolCard.tsx b/plugins/explore/src/components/ToolCard/ToolCard.tsx index f6137d9c01..a39806dceb 100644 --- a/plugins/explore/src/components/ToolCard/ToolCard.tsx +++ b/plugins/explore/src/components/ToolCard/ToolCard.tsx @@ -74,7 +74,7 @@ export const ToolCard = ({ card, objectFit }: Props) => { })} /> - + {title}{' '} {lifecycle && lifecycle.toLocaleLowerCase('en-US') !== 'ga' && (