From 3913fd8ef526f91848fe52a2d3aa9c3f8efe6789 Mon Sep 17 00:00:00 2001 From: Aditya Kumar Date: Fri, 15 Mar 2024 13:32:06 +0530 Subject: [PATCH] Add ESLint Rule to Kafka Plugin Signed-off-by: Aditya Kumar --- .changeset/wise-fireants-doubt.md | 5 +++++ plugins/kafka/.eslintrc.js | 6 +++++- .../ConsumerGroupOffsets/ConsumerGroupOffsets.tsx | 4 +++- 3 files changed, 13 insertions(+), 2 deletions(-) create mode 100644 .changeset/wise-fireants-doubt.md diff --git a/.changeset/wise-fireants-doubt.md b/.changeset/wise-fireants-doubt.md new file mode 100644 index 0000000000..7ec973b64c --- /dev/null +++ b/.changeset/wise-fireants-doubt.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-kafka': patch +--- + +Added ESLint rule `no-top-level-material-ui-4-imports` in the Kafka plugin to migrate the Material UI imports. diff --git a/plugins/kafka/.eslintrc.js b/plugins/kafka/.eslintrc.js index e2a53a6ad2..a2d8179106 100644 --- a/plugins/kafka/.eslintrc.js +++ b/plugins/kafka/.eslintrc.js @@ -1 +1,5 @@ -module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { + rules: { + '@backstage/no-top-level-material-ui-4-imports': 'error', + }, +}); diff --git a/plugins/kafka/src/components/ConsumerGroupOffsets/ConsumerGroupOffsets.tsx b/plugins/kafka/src/components/ConsumerGroupOffsets/ConsumerGroupOffsets.tsx index d166195cf9..5aab647b25 100644 --- a/plugins/kafka/src/components/ConsumerGroupOffsets/ConsumerGroupOffsets.tsx +++ b/plugins/kafka/src/components/ConsumerGroupOffsets/ConsumerGroupOffsets.tsx @@ -14,7 +14,9 @@ * limitations under the License. */ -import { Box, Grid, Typography } from '@material-ui/core'; +import Box from '@material-ui/core/Box'; +import Grid from '@material-ui/core/Grid'; +import Typography from '@material-ui/core/Typography'; import RetryIcon from '@material-ui/icons/Replay'; import React from 'react'; import { useConsumerGroupsOffsetsForEntity } from './useConsumerGroupsOffsetsForEntity';