From 39001f409125fc33814c89ba994f83fd544a7fec Mon Sep 17 00:00:00 2001 From: blam Date: Mon, 14 Oct 2024 16:27:53 +0200 Subject: [PATCH] chore: changeset Signed-off-by: blam --- .changeset/thin-doors-rule.md | 5 +++++ packages/core-plugin-api/src/routing/RouteRef.test.ts | 10 ++++------ 2 files changed, 9 insertions(+), 6 deletions(-) create mode 100644 .changeset/thin-doors-rule.md diff --git a/.changeset/thin-doors-rule.md b/.changeset/thin-doors-rule.md new file mode 100644 index 0000000000..20823bb79f --- /dev/null +++ b/.changeset/thin-doors-rule.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-plugin-api': patch +--- + +Fixing issue with types for `ParamKeys` leading to type mismatches across versions diff --git a/packages/core-plugin-api/src/routing/RouteRef.test.ts b/packages/core-plugin-api/src/routing/RouteRef.test.ts index 58013261ab..489900d892 100644 --- a/packages/core-plugin-api/src/routing/RouteRef.test.ts +++ b/packages/core-plugin-api/src/routing/RouteRef.test.ts @@ -78,21 +78,19 @@ describe('RouteRef', () => { validateType>(['x', 'y']); // @ts-expect-error - validateType>(['asd']); + validateType>(['foo']); validateType>([]); // @ts-expect-error validateType>([1]); - validateType>(['migrationId']); + validateType>(['foo']); // @ts-expect-error validateType>([1]); - validateType>([ - 'migrationId', - ]); + validateType>(['foo']); // @ts-expect-error - validateType>(['asd']); + validateType>(['foo']); validateType>([]); expect(true).toBeDefined();