paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 50 Packages Projects Releases Wiki Activity

Merge pull request #10558 from backstage/blam/node16types

Browse Source 
chore: @node/types -> 16.x
This commit is contained in:
Ben Lambert
2022-04-06 15:47:21 +02:00
committed by GitHub
parent 5b9559ca9e 230ad0826f
commit 38d6a4745c
72 changed files with 167 additions and 100 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/e2e-test/package.json
+1 -1
View File
@@ -32,7 +32,7 @@
"@backstage/cli-common": "^0.1.8",
"@backstage/errors": "^1.0.0",
"@types/fs-extra": "^9.0.1",
"@types/node": "^14.14.32",
"@types/node": "^16.11.26",
"@types/puppeteer": "^5.4.4",
"chalk": "^4.0.0",
"commander": "^6.1.0",
packages/e2e-test/src/commands/run.ts
+6 -6
View File
@@ -380,9 +380,9 @@ async function testAppServe(pluginName: string, appDir: string) {
}
} finally {
// Kill entire process group, otherwise we'll end up with hanging serve processes
await new Promise<void>((res, rej) =>
killTree(startApp.pid, err => (err ? rej(err) : res())),
);
await new Promise<void>((res, rej) => {
killTree(startApp.pid!, err => (err ? rej(err) : res()));
});
}
try {
@@ -485,9 +485,9 @@ async function testBackendStart(appDir: string, isPostgres: boolean) {
} finally {
print('Stopping the child process');
// Kill entire process group, otherwise we'll end up with hanging serve processes
await new Promise<void>((res, rej) =>
killTree(child.pid, err => (err ? rej(err) : res())),
);
await new Promise<void>((res, rej) => {
killTree(child.pid!, err => (err ? rej(err) : res()));
});
}
try {