From 38b1a35a83f549dc8ff598972febf878461be6bc Mon Sep 17 00:00:00 2001 From: Tavi Nolan Date: Thu, 4 Apr 2024 16:21:03 +0100 Subject: [PATCH] updated githubPullRequest Signed-off-by: Tavi Nolan --- .../src/actions/githubPullRequest.test.ts | 2 +- .../src/actions/githubPullRequest.ts | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.test.ts b/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.test.ts index 86197285f2..150ed39e50 100644 --- a/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.test.ts +++ b/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.test.ts @@ -229,7 +229,7 @@ describe('createPublishGithubPullRequestAction', () => { expect(ctx.output).toHaveBeenCalledWith('pullRequestNumber', 123); }); - it('handles dry run correctly', async () => { + it('sets correct outputs during dry run', async () => { ctx.isDryRun = true; await instance.handler(ctx); diff --git a/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.ts b/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.ts index e058bfcd94..99e442f74a 100644 --- a/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.ts +++ b/plugins/scaffolder-backend-module-github/src/actions/githubPullRequest.ts @@ -322,14 +322,11 @@ export const createPublishGithubPullRequestAction = ( ); if (ctx.isDryRun) { - ctx.logger.info( - `Dry run arguments: ${{ - ...ctx.input, - }}`, - ); + ctx.logger.info(`Performing dry run of creating pull request`); ctx.output('targetBranchName', branchName); ctx.output('remoteUrl', repoUrl); ctx.output('pullRequestNumber', 43); + ctx.logger.info(`Dry run complete`); return; }