paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 32 Packages Projects Releases Wiki Activity

Safe nullish check with git-url-parse library responses

Browse Source
This commit is contained in:
Himanshu Mishra
2021-01-18 23:04:31 +01:00
parent baeed36324
commit 380dd626fb
3 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/backend-common/src/reading/GithubUrlReader.ts
+1 -1
View File
@@ -130,7 +130,7 @@ export class GithubUrlReader implements UrlReader {
// ref is an empty string if no branch is set in provided url to readTree.
// Use GitHub API to get the default branch of the repository.
const branch = ref === '' ? repoResponseJson.default_branch : ref;
const branch = ref || repoResponseJson.default_branch;
const branchesApiUrl = repoResponseJson.branches_url;
// Fetch the latest commit in the provided or default branch to compare against
packages/backend-common/src/reading/GitlabUrlReader.ts
+1 -1
View File
@@ -99,7 +99,7 @@ export class GitlabUrlReader implements UrlReader {
const projectGitlabResponseJson = await projectGitlabResponse.json();
// ref is an empty string if no branch is set in provided url to readTree.
const branch = ref === '' ? projectGitlabResponseJson.default_branch : ref;
const branch = ref || projectGitlabResponseJson.default_branch;
// Fetch the latest commit in the provided or default branch to compare against
// the provided sha.