From 37421bce0218d7595d1bcd4a7bb51aff1dc90130 Mon Sep 17 00:00:00 2001 From: Tim Hansen Date: Fri, 20 Dec 2024 08:37:52 -0700 Subject: [PATCH] Fix formFieldsApi resolution in useCustomFieldExtensions hook Signed-off-by: Tim Hansen --- .changeset/rich-penguins-stare.md | 5 +++++ .../scaffolder-react/src/hooks/useCustomFieldExtensions.ts | 6 +++--- 2 files changed, 8 insertions(+), 3 deletions(-) create mode 100644 .changeset/rich-penguins-stare.md diff --git a/.changeset/rich-penguins-stare.md b/.changeset/rich-penguins-stare.md new file mode 100644 index 0000000000..0993b0fb55 --- /dev/null +++ b/.changeset/rich-penguins-stare.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-scaffolder-react': patch +--- + +Fixed scaffolder form fields not resolving correctly in the `useCustomFieldExtensions` hook. diff --git a/plugins/scaffolder-react/src/hooks/useCustomFieldExtensions.ts b/plugins/scaffolder-react/src/hooks/useCustomFieldExtensions.ts index d1e670330e..d44fc18e07 100644 --- a/plugins/scaffolder-react/src/hooks/useCustomFieldExtensions.ts +++ b/plugins/scaffolder-react/src/hooks/useCustomFieldExtensions.ts @@ -34,11 +34,11 @@ export const useCustomFieldExtensions = < ) => { // Get custom fields created with FormFieldBlueprint const formFieldsApi = useApi(formFieldsApiRef); - const [{ result: blueprintFields }, methods] = useAsync( - formFieldsApi.getFormFields, + const [{ result: blueprintFields }, { execute }] = useAsync( + () => formFieldsApi.getFormFields(), [], ); - useMountEffect(methods.execute); + useMountEffect(execute); // Get custom fields created with ScaffolderFieldExtensions const outletFields = useElementFilter(outlet, elements =>