more strict error type checking in most packages and backend plugins
Signed-off-by: Patrik Oldsberg <poldsberg@gmail.com>
This commit is contained in:
@@ -35,6 +35,7 @@
|
||||
"@backstage/backend-common": "^0.9.4",
|
||||
"@backstage/catalog-model": "^0.9.3",
|
||||
"@backstage/config": "^0.1.10",
|
||||
"@backstage/errors": "^0.1.2",
|
||||
"@backstage/plugin-kubernetes-common": "^0.1.4",
|
||||
"@google-cloud/container": "^2.2.0",
|
||||
"@kubernetes/client-node": "^0.15.0",
|
||||
|
||||
@@ -213,7 +213,7 @@ describe('GkeClusterLocator', () => {
|
||||
} as any);
|
||||
|
||||
await expect(sut.getClusters()).rejects.toThrow(
|
||||
'There was an error retrieving clusters from GKE for projectId=some-project region=some-region : [some error]',
|
||||
'There was an error retrieving clusters from GKE for projectId=some-project region=some-region; caused by Error: some error',
|
||||
);
|
||||
|
||||
expect(mockedListClusters).toBeCalledTimes(1);
|
||||
|
||||
@@ -15,6 +15,7 @@
|
||||
*/
|
||||
|
||||
import { Config } from '@backstage/config';
|
||||
import { ForwardedError } from '@backstage/errors';
|
||||
import * as container from '@google-cloud/container';
|
||||
import { GKEClusterDetails, KubernetesClustersSupplier } from '../types/types';
|
||||
|
||||
@@ -65,8 +66,9 @@ export class GkeClusterLocator implements KubernetesClustersSupplier {
|
||||
skipTLSVerify,
|
||||
}));
|
||||
} catch (e) {
|
||||
throw new Error(
|
||||
`There was an error retrieving clusters from GKE for projectId=${projectId} region=${region} : [${e.message}]`,
|
||||
throw new ForwardedError(
|
||||
`There was an error retrieving clusters from GKE for projectId=${projectId} region=${region}`,
|
||||
e,
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user