From 05be42097133f5d26415b170ab102b0cf515f0e9 Mon Sep 17 00:00:00 2001 From: Matt Ng Date: Thu, 19 May 2022 18:06:42 -0400 Subject: [PATCH 1/3] Header Hierarchy Jump on Catalog Import Page Signed-off-by: Matt Ng --- .changeset/violet-apples-repair.md | 5 +++++ .../src/components/ImportInfoCard/ImportInfoCard.tsx | 5 +++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/violet-apples-repair.md diff --git a/.changeset/violet-apples-repair.md b/.changeset/violet-apples-repair.md new file mode 100644 index 0000000000..8bf6a6c1c9 --- /dev/null +++ b/.changeset/violet-apples-repair.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-catalog-import': minor +--- + +Updated catalog import page text so they go in the correct hierarchy order diff --git a/plugins/catalog-import/src/components/ImportInfoCard/ImportInfoCard.tsx b/plugins/catalog-import/src/components/ImportInfoCard/ImportInfoCard.tsx index c879cbe998..339d71b476 100644 --- a/plugins/catalog-import/src/components/ImportInfoCard/ImportInfoCard.tsx +++ b/plugins/catalog-import/src/components/ImportInfoCard/ImportInfoCard.tsx @@ -54,6 +54,7 @@ export const ImportInfoCard = (props: ImportInfoCardProps) => { return ( { Enter the URL to your source code repository to add it to {appTitle}. - Link to an existing entity file + Link to an existing entity file Example: {exampleLocationUrl} @@ -72,7 +73,7 @@ export const ImportInfoCard = (props: ImportInfoCardProps) => { {hasGithubIntegration && ( <> - + Link to a repository{' '} From 68a63cf2e696fd57f4fd7e8afc96369f5966ec1b Mon Sep 17 00:00:00 2001 From: Matt Ng Date: Fri, 20 May 2022 13:28:39 -0400 Subject: [PATCH 2/3] Changing the header hierarchy while keeping the original styling Signed-off-by: Matt Ng --- .../src/components/ImportInfoCard/ImportInfoCard.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/catalog-import/src/components/ImportInfoCard/ImportInfoCard.tsx b/plugins/catalog-import/src/components/ImportInfoCard/ImportInfoCard.tsx index 339d71b476..7fa6b13a82 100644 --- a/plugins/catalog-import/src/components/ImportInfoCard/ImportInfoCard.tsx +++ b/plugins/catalog-import/src/components/ImportInfoCard/ImportInfoCard.tsx @@ -63,7 +63,9 @@ export const ImportInfoCard = (props: ImportInfoCardProps) => { Enter the URL to your source code repository to add it to {appTitle}. - Link to an existing entity file + + Link to an existing entity file + Example: {exampleLocationUrl} @@ -73,7 +75,7 @@ export const ImportInfoCard = (props: ImportInfoCardProps) => { {hasGithubIntegration && ( <> - + Link to a repository{' '} From cd8ad6d6003477a5cca02b0cba04b5aadd2ab7aa Mon Sep 17 00:00:00 2001 From: Matt Ng Date: Fri, 20 May 2022 13:30:16 -0400 Subject: [PATCH 3/3] updating to call this a patch Signed-off-by: Matt Ng --- .changeset/violet-apples-repair.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/violet-apples-repair.md b/.changeset/violet-apples-repair.md index 8bf6a6c1c9..a6be2797f6 100644 --- a/.changeset/violet-apples-repair.md +++ b/.changeset/violet-apples-repair.md @@ -1,5 +1,5 @@ --- -'@backstage/plugin-catalog-import': minor +'@backstage/plugin-catalog-import': patch --- Updated catalog import page text so they go in the correct hierarchy order