From 367e3bf130a5cfa9ee0c31de32d5440250636113 Mon Sep 17 00:00:00 2001 From: Jeremy Guarini Date: Mon, 8 Nov 2021 09:29:21 -0800 Subject: [PATCH] updated timestamp conversion to use Luxon and adrs-adr012 guideline, added luxon as dependency Signed-off-by: Jeremy Guarini --- plugins/code-coverage/package.json | 1 + .../CoverageHistoryChart/CoverageHistoryChart.tsx | 6 +++++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/plugins/code-coverage/package.json b/plugins/code-coverage/package.json index 2b09b4d99f..8b6b4aef09 100644 --- a/plugins/code-coverage/package.json +++ b/plugins/code-coverage/package.json @@ -33,6 +33,7 @@ "@material-ui/lab": "4.0.0-alpha.57", "@material-ui/styles": "^4.11.0", "highlight.js": "^10.6.0", + "luxon": "^2.1.0", "react": "^16.13.1", "react-dom": "^16.13.1", "react-router": "6.0.0-beta.0", diff --git a/plugins/code-coverage/src/components/CoverageHistoryChart/CoverageHistoryChart.tsx b/plugins/code-coverage/src/components/CoverageHistoryChart/CoverageHistoryChart.tsx index a251bb1a68..4291599098 100644 --- a/plugins/code-coverage/src/components/CoverageHistoryChart/CoverageHistoryChart.tsx +++ b/plugins/code-coverage/src/components/CoverageHistoryChart/CoverageHistoryChart.tsx @@ -46,6 +46,8 @@ import { codeCoverageApiRef } from '../../api'; import { Progress, ResponseErrorPanel } from '@backstage/core-components'; import { useApi } from '@backstage/core-plugin-api'; +import { DateTime } from 'luxon'; + type Coverage = 'line' | 'branch'; const useStyles = makeStyles(theme => ({ @@ -71,7 +73,9 @@ const getTrendIcon = (trend: number, classes: ClassNameMap) => { // convert timestamp to human friendly form function formatDateToHuman(timeStamp: string | number) { - return new Date(timeStamp).toUTCString(); + return DateTime.fromMillis(Number(timeStamp)).toLocaleString( + DateTime.DATETIME_MED, + ); } export const CoverageHistoryChart = () => {