From 87ab76e55c6f1ff4936e51b23202af9fdd945749 Mon Sep 17 00:00:00 2001 From: Dang Huynh Date: Fri, 6 Jan 2023 15:23:38 -0600 Subject: [PATCH 1/2] Fixed AWS SDK V3 bug with s3ForcePathStyle Signed-off-by: Dang Huynh --- .changeset/cyan-deers-walk.md | 5 +++++ plugins/techdocs-node/src/stages/publish/awsS3.ts | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) create mode 100644 .changeset/cyan-deers-walk.md diff --git a/.changeset/cyan-deers-walk.md b/.changeset/cyan-deers-walk.md new file mode 100644 index 0000000000..2a9265090b --- /dev/null +++ b/.changeset/cyan-deers-walk.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-techdocs-node': minor +--- + +Fixed bug caused by recent migration to AWS SDK V3 for techdocs-node. Instead of s3ForcePathStyle, forcePathStyle should be passed. diff --git a/plugins/techdocs-node/src/stages/publish/awsS3.ts b/plugins/techdocs-node/src/stages/publish/awsS3.ts index a13baef926..6b528cfd30 100644 --- a/plugins/techdocs-node/src/stages/publish/awsS3.ts +++ b/plugins/techdocs-node/src/stages/publish/awsS3.ts @@ -152,7 +152,7 @@ export class AwsS3Publish implements PublisherBase { // AWS forcePathStyle is an optional config. If missing, it defaults to false. Needs to be enabled for cases // where endpoint url points to locally hosted S3 compatible storage like Localstack - const s3ForcePathStyle = config.getOptionalBoolean( + const forcePathStyle = config.getOptionalBoolean( 'techdocs.publisher.awsS3.s3ForcePathStyle', ); @@ -161,7 +161,7 @@ export class AwsS3Publish implements PublisherBase { credentialDefaultProvider: () => sdkCredentialProvider, ...(region && { region }), ...(endpoint && { endpoint }), - ...(s3ForcePathStyle && { s3ForcePathStyle }), + ...(forcePathStyle && { forcePathStyle }), }); const legacyPathCasing = From c2df6f01927fabcb51fe6a8bed4dd3a9e0db301e Mon Sep 17 00:00:00 2001 From: Dang Huynh Date: Tue, 10 Jan 2023 08:53:28 -0600 Subject: [PATCH 2/2] Minor change to patch Signed-off-by: Dang Huynh --- .changeset/cyan-deers-walk.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/cyan-deers-walk.md b/.changeset/cyan-deers-walk.md index 2a9265090b..236eb7935b 100644 --- a/.changeset/cyan-deers-walk.md +++ b/.changeset/cyan-deers-walk.md @@ -1,5 +1,5 @@ --- -'@backstage/plugin-techdocs-node': minor +'@backstage/plugin-techdocs-node': patch --- Fixed bug caused by recent migration to AWS SDK V3 for techdocs-node. Instead of s3ForcePathStyle, forcePathStyle should be passed.