Merge pull request #2741 from spotify/rugvip/short

config-loader: add support for new short-form secret syntax
2020-10-05 13:30:04 +02:00
parent 86e5c629de eaf169c07a
commit 34eb3a13c8
19 changed files with 188 additions and 179 deletions
@@ -57,8 +57,7 @@ proxy:
    target: https://circleci.com/api/v1.1
    headers:
      Circle-Token:
-        $secret:
-          env: CIRCLECI_AUTH_TOKEN
+        $env: CIRCLECI_AUTH_TOKEN
 ```

 5. Get and provide `CIRCLECI_AUTH_TOKEN` as env variable (https://circleci.com/docs/api/#add-an-api-token)
@@ -30,8 +30,7 @@ proxy:
    changeOrigin: true
    headers:
      Authorization:
-        $secret:
-          env: JENKINS_BASIC_AUTH_HEADER
+        $env: JENKINS_BASIC_AUTH_HEADER
 ```

 4. Add an environment variable which contains the Jenkins credentials, (note: use an API token not your password)
@@ -10,8 +10,7 @@ The following values are read from the configuration file.
 rollbar:
  organization: spotify
  accountToken:
-    $secret:
-      env: ROLLBAR_ACCOUNT_TOKEN
+    $env: ROLLBAR_ACCOUNT_TOKEN
 ```

 _NOTE: The `ROLLBAR_ACCOUNT_TOKEN` environment variable must be set to a read
@@ -55,8 +55,7 @@ const ServiceEntityPage = ({ entity }: { entity: Entity }) => (
 rollbar:
  organization: spotify
  accountToken:
-    $secret:
-      env: ROLLBAR_ACCOUNT_TOKEN
+    $env: ROLLBAR_ACCOUNT_TOKEN
 ```

 7. Annotate entities with the rollbar project slug