From 3383f82c58e0f344a7e530bb6096e43b11a6a763 Mon Sep 17 00:00:00 2001
From: NIKUNJ LALITKUMAR HUDKA <nikunjhudka123@gmail.com>
Date: Fri, 26 Apr 2024 01:28:40 -0300
Subject: [PATCH] feat: no need to pass value in autocomplete as we have
 renderOptions

Signed-off-by: NIKUNJ LALITKUMAR HUDKA <nikunjhudka123@gmail.com>
---
 .../MultiEntityPicker/MultiEntityPicker.tsx   | 28 ++++---------------
 1 file changed, 6 insertions(+), 22 deletions(-)

diff --git a/plugins/scaffolder/src/components/fields/MultiEntityPicker/MultiEntityPicker.tsx b/plugins/scaffolder/src/components/fields/MultiEntityPicker/MultiEntityPicker.tsx
index 0a0fcfdc2b..073b364720 100644
--- a/plugins/scaffolder/src/components/fields/MultiEntityPicker/MultiEntityPicker.tsx
+++ b/plugins/scaffolder/src/components/fields/MultiEntityPicker/MultiEntityPicker.tsx
@@ -71,14 +71,8 @@ export const MultiEntityPicker = (props: MultiEntityPickerProps) => {
     const { items } = await catalogApi.getEntities(
       catalogFilter ? { filter: catalogFilter } : undefined,
     );
-    const primaryTitles: string[] = [];
-    for (const item of items) {
-      const entityPresentation = (await entityPresentationApi.forEntity(item)
-        ?.promise) as EntityRefPresentationSnapshot[];
-      entityPresentation.map(e => primaryTitles.push(e.primaryTitle));
-    }
 
-    return { items, primaryTitles };
+    return items;
   });
   const allowArbitraryValues =
     uiSchema['ui:options']?.allowArbitraryValues ?? true;
@@ -134,10 +128,10 @@ export const MultiEntityPicker = (props: MultiEntityPickerProps) => {
   );
 
   useEffect(() => {
-    if (entities?.items?.length === 1) {
-      onChange([stringifyEntityRef(entities.items[0])]);
+    if (entities?.length === 1) {
+      onChange([stringifyEntityRef(entities[0])]);
     }
-  }, [entities?.items, onChange]);
+  }, [entities, onChange]);
 
   return (
     <FormControl
@@ -148,21 +142,11 @@ export const MultiEntityPicker = (props: MultiEntityPickerProps) => {
       <Autocomplete
         multiple
         filterSelectedOptions
-        disabled={entities?.items?.length === 1}
+        disabled={entities?.length === 1}
         id={idSchema?.$id}
-        value={
-          // Since free solo can be enabled, attempt to parse as a full entity ref first, then fall
-          //  back to the given value.
-          entities?.items?.filter(
-            e => formData && formData.includes(stringifyEntityRef(e)),
-          ) ??
-          (allowArbitraryValues && formData
-            ? entities?.primaryTitles || []
-            : [])
-        }
         loading={loading}
         onChange={onSelect}
-        options={entities?.items || []}
+        options={entities || []}
         renderOption={option => <EntityDisplayName entityRef={option} />}
         getOptionLabel={option =>
           // option can be a string due to freeSolo.