Merge pull request #11523 from cowboyd/propagate-index-failure

Don't swallow indexing failures
2022-05-18 16:00:38 +02:00
parent 2e3627050c e7794a0aaa
commit 3345dbf84b
2 changed files with 9 additions and 4 deletions
@@ -128,7 +128,7 @@ export class IndexBuilder {
          const indexer = await this.searchEngine.getIndexer(type);

          // Compose collator/decorators/indexer into a pipeline
-          return new Promise<void>(done => {
+          return new Promise<void>((resolve, reject) => {
            pipeline(
              [collator, ...decorators, indexer],
              (error: NodeJS.ErrnoException | null) => {
@@ -136,12 +136,12 @@ export class IndexBuilder {
                  this.logger.error(
                    `Collating documents for ${type} failed: ${error}`,
                  );
+                  reject(error);
                } else {
+                  // Signal index pipeline completion!
                  this.logger.info(`Collating documents for ${type} succeeded`);
+                  resolve();
                }
-
-                // Signal index pipeline completion!
-                done();
              },
            );
          });