From 332a3702b345d6328e1f30ba760b9569d54f72f6 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Sat, 14 Oct 2023 12:54:45 +0200 Subject: [PATCH] frontend-app-api: cleanup route binding config reading Signed-off-by: Patrik Oldsberg --- .../frontend-app-api/src/routing/resolveRouteBindings.ts | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/frontend-app-api/src/routing/resolveRouteBindings.ts b/packages/frontend-app-api/src/routing/resolveRouteBindings.ts index c98e36a75b..f5a2e5bd94 100644 --- a/packages/frontend-app-api/src/routing/resolveRouteBindings.ts +++ b/packages/frontend-app-api/src/routing/resolveRouteBindings.ts @@ -21,6 +21,7 @@ import { } from '@backstage/frontend-plugin-api'; import { RouteRefsById } from './collectRouteIds'; import { Config } from '@backstage/config'; +import { JsonObject } from '@backstage/types'; /** * Extracts a union of the keys in a map whose value extends the given type @@ -109,11 +110,7 @@ export function resolveRouteBindings( return result; } - const bindings = bindingsConfig.get(); - if (bindings === null || typeof bindings !== 'object') { - throw new Error('Invalid config at app.routes.bindings, must be an object'); - } - + const bindings = bindingsConfig.get(); for (const [externalRefId, targetRefId] of Object.entries(bindings)) { if (typeof targetRefId !== 'string' || targetRefId === '') { throw new Error(