From 33060b59c1f1b1c3b5ee7e9e24397e7c8834f502 Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 7 Aug 2025 11:19:58 +0200 Subject: [PATCH] repo-tools: stop ignoring BUI Signed-off-by: Patrik Oldsberg --- .changeset/shiny-rats-accept.md | 5 +++++ .../src/commands/knip-reports/knip-extractor.ts | 10 +--------- 2 files changed, 6 insertions(+), 9 deletions(-) create mode 100644 .changeset/shiny-rats-accept.md diff --git a/.changeset/shiny-rats-accept.md b/.changeset/shiny-rats-accept.md new file mode 100644 index 0000000000..1c9bb96764 --- /dev/null +++ b/.changeset/shiny-rats-accept.md @@ -0,0 +1,5 @@ +--- +'@backstage/repo-tools': patch +--- + +Removed build-in ignore of the `packages/canon` package for knip reports. diff --git a/packages/repo-tools/src/commands/knip-reports/knip-extractor.ts b/packages/repo-tools/src/commands/knip-reports/knip-extractor.ts index 3f10aea929..a97d1ddd8f 100644 --- a/packages/repo-tools/src/commands/knip-reports/knip-extractor.ts +++ b/packages/repo-tools/src/commands/knip-reports/knip-extractor.ts @@ -21,11 +21,6 @@ import fs from 'fs-extra'; import type { KnipConfig } from 'knip'; import { createBinRunner } from '../util'; -// Ignore these -const ignoredPackages = [ - 'packages/ui', // storybook config is different from the rest -]; - interface KnipExtractionOptions { packageDirs: string[]; isLocalBuild: boolean; @@ -104,10 +99,7 @@ async function handlePackage({ isLocalBuild, }: KnipPackageOptions) { console.log(`## Processing ${packageDir}`); - if (ignoredPackages.includes(packageDir)) { - console.log(`Skipping ${packageDir}`); - return; - } + const fullDir = cliPaths.resolveTargetRoot(packageDir); const reportPath = resolvePath(fullDir, 'knip-report.md'); const run = createBinRunner(cliPaths.targetRoot, '');