paulononato/backstage
1
0
Fork 0
Code Issues Pull Requests Actions 28 Packages Projects Releases Wiki Activity

Bake subquery into the delete clause

Browse Source 
Signed-off-by: Jussi Hallila <jussi@hallila.com>
This commit is contained in:
Jussi Hallila
2023-01-16 12:01:07 +01:00
parent b48317cfc6
commit 3262f0ec83
1 changed files with 38 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files
plugins/tech-insights-backend/src/service/persistence/TechInsightsDatabase.ts
+38 -36
View File
@@ -212,43 +212,45 @@ export class TechInsightsDatabase implements TechInsightsStore {
factRetrieverId: string,
maxItems: number,
) {
const deletables = await tx<RawDbFactRow>('facts')
.where({ id: factRetrieverId })
.and.whereIn('entity', db =>
db.distinct('entity').where({ id: factRetrieverId }),
)
.and.leftJoin(
joinTable =>
joinTable
.select('*')
.from(
this.db('facts')
.column(
{ fid: 'id' },
{ fentity: 'entity' },
{ ftimestamp: 'timestamp' },
)
.column(
this.db.raw(
'row_number() over (partition by id, entity order by timestamp desc) as fact_rank',
),
)
.as('ranks'),
)
.where('fact_rank', '<=', maxItems)
.as('filterjoin'),
joinClause => {
joinClause
.on('filterjoin.fid', 'facts.id')
.on('filterjoin.fentity', 'facts.entity')
.on('filterjoin.ftimestamp', 'facts.timestamp');
},
)
.whereNull('filterjoin.fid');
const deletionFilterQuery = (subTx: Knex.QueryBuilder<any, unknown[]>) =>
subTx
.select(['id', 'entity', 'timestamp'])
.from('facts')
.where({ id: factRetrieverId })
.and.whereIn('entity', db =>
db.distinct('entity').where({ id: factRetrieverId }),
)
.and.leftJoin(
joinTable =>
joinTable
.select('*')
.from(
this.db('facts')
.column(
{ fid: 'id' },
{ fentity: 'entity' },
{ ftimestamp: 'timestamp' },
)
.column(
this.db.raw(
'row_number() over (partition by id, entity order by timestamp desc) as fact_rank',
),
)
.as('ranks'),
)
.where('fact_rank', '<=', maxItems)
.as('filterjoin'),
joinClause => {
joinClause
.on('filterjoin.fid', 'facts.id')
.on('filterjoin.fentity', 'facts.entity')
.on('filterjoin.ftimestamp', 'facts.timestamp');
},
)
.whereNull('filterjoin.fid');
await tx('facts')
.whereIn(
['id', 'entity', 'timestamp'],
deletables.map(it => [it.id, it.entity, it.timestamp]),
.whereIn(['id', 'entity', 'timestamp'], database =>
deletionFilterQuery(database),
)
.delete();
}