From 3236071136feb402a2b6fa107677e90d4176860c Mon Sep 17 00:00:00 2001 From: Brian Fletcher Date: Wed, 27 Oct 2021 12:46:47 +0100 Subject: [PATCH] change name of task worker builder function also makes it async Signed-off-by: Brian Fletcher --- .../src/scaffolder/tasks/TaskWorker.test.ts | 6 +++--- .../scaffolder-backend/src/scaffolder/tasks/TaskWorker.ts | 2 +- plugins/scaffolder-backend/src/service/router.ts | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.test.ts b/plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.test.ts index 3cb73abb85..f33b9182ce 100644 --- a/plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.test.ts +++ b/plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.test.ts @@ -82,7 +82,7 @@ describe('TaskWorker', () => { it('should call the legacy workflow runner when the apiVersion is not beta3', async () => { const broker = new StorageTaskBroker(storage, logger); - const taskWorker = TaskWorker.createWorker({ + const taskWorker = TaskWorker.create({ logger, workingDirectory, integrations, @@ -113,7 +113,7 @@ describe('TaskWorker', () => { it('should call the default workflow runner when the apiVersion is beta3', async () => { const broker = new StorageTaskBroker(storage, logger); - const taskWorker = TaskWorker.createWorker({ + const taskWorker = TaskWorker.create({ logger, workingDirectory, integrations, @@ -142,7 +142,7 @@ describe('TaskWorker', () => { }); const broker = new StorageTaskBroker(storage, logger); - const taskWorker = TaskWorker.createWorker({ + const taskWorker = TaskWorker.create({ logger, workingDirectory, integrations, diff --git a/plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.ts b/plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.ts index d22bdc4e30..8d89735361 100644 --- a/plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.ts +++ b/plugins/scaffolder-backend/src/scaffolder/tasks/TaskWorker.ts @@ -56,7 +56,7 @@ export type CreateWorkerOptions = { export class TaskWorker { private constructor(private readonly options: TaskWorkerOptions) {} - static createWorker(options: CreateWorkerOptions) { + static async create(options: CreateWorkerOptions): Promise { const { taskBroker, logger, diff --git a/plugins/scaffolder-backend/src/service/router.ts b/plugins/scaffolder-backend/src/service/router.ts index 700f2c6e6f..231c998f8b 100644 --- a/plugins/scaffolder-backend/src/service/router.ts +++ b/plugins/scaffolder-backend/src/service/router.ts @@ -99,7 +99,7 @@ export async function createRouter( const workers = []; for (let i = 0; i < (taskWorkers || 1); i++) { - const worker = TaskWorker.createWorker({ + const worker = await TaskWorker.create({ taskBroker, actionRegistry, integrations,