From 31d58ae7e4bf95fbde95f5cc2ad530d4296bbbfb Mon Sep 17 00:00:00 2001 From: Aditya Kumar Date: Wed, 13 Mar 2024 09:33:30 +0530 Subject: [PATCH] Added @backstage/no-top-level-material-ui-4-imports rule to plugins/airbrake Signed-off-by: Aditya Kumar --- .changeset/hot-moles-lay.md | 5 +++++ plugins/airbrake/.eslintrc.js | 6 +++++- plugins/airbrake/dev/components/ApiBar/ApiBar.tsx | 3 ++- .../EntityAirbrakeWidget/EntityAirbrakeWidget.tsx | 3 ++- 4 files changed, 14 insertions(+), 3 deletions(-) create mode 100644 .changeset/hot-moles-lay.md diff --git a/.changeset/hot-moles-lay.md b/.changeset/hot-moles-lay.md new file mode 100644 index 0000000000..90adcbd07b --- /dev/null +++ b/.changeset/hot-moles-lay.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-airbrake': patch +--- + +added an optional ESLint rule - no-top-level-material-ui-4-imports - which has an auto fix function to migrate the imports and using it migrated the imports diff --git a/plugins/airbrake/.eslintrc.js b/plugins/airbrake/.eslintrc.js index e2a53a6ad2..9d5b45a010 100644 --- a/plugins/airbrake/.eslintrc.js +++ b/plugins/airbrake/.eslintrc.js @@ -1 +1,5 @@ -module.exports = require('@backstage/cli/config/eslint-factory')(__dirname); +module.exports = require('@backstage/cli/config/eslint-factory')(__dirname, { + rules: { + '@backstage/no-top-level-material-ui-4-imports': 'error', + }, + }); \ No newline at end of file diff --git a/plugins/airbrake/dev/components/ApiBar/ApiBar.tsx b/plugins/airbrake/dev/components/ApiBar/ApiBar.tsx index 7c79dc8363..f75bc4160f 100644 --- a/plugins/airbrake/dev/components/ApiBar/ApiBar.tsx +++ b/plugins/airbrake/dev/components/ApiBar/ApiBar.tsx @@ -14,7 +14,8 @@ * limitations under the License. */ import React from 'react'; -import { makeStyles, TextField } from '@material-ui/core'; +import TextField from '@material-ui/core/TextField'; +import { makeStyles } from '@material-ui/core/styles'; import { Context } from '../ContextProvider'; const useStyles = makeStyles(theme => ({ diff --git a/plugins/airbrake/src/components/EntityAirbrakeWidget/EntityAirbrakeWidget.tsx b/plugins/airbrake/src/components/EntityAirbrakeWidget/EntityAirbrakeWidget.tsx index 666a7ffea2..f63c0db86b 100644 --- a/plugins/airbrake/src/components/EntityAirbrakeWidget/EntityAirbrakeWidget.tsx +++ b/plugins/airbrake/src/components/EntityAirbrakeWidget/EntityAirbrakeWidget.tsx @@ -22,7 +22,8 @@ import { Progress, } from '@backstage/core-components'; import { useApi } from '@backstage/core-plugin-api'; -import { Grid, Typography } from '@material-ui/core'; +import Grid from '@material-ui/core/Grid'; +import Typography from '@material-ui/core/Typography'; import { makeStyles } from '@material-ui/core/styles'; import React from 'react'; import useAsync from 'react-use/lib/useAsync';