From 30e92e77097540746d66d2d3b0330e8cf30119d9 Mon Sep 17 00:00:00 2001
From: NIKUNJ LALITKUMAR HUDKA <nikunjhudka123@gmail.com>
Date: Mon, 22 Apr 2024 23:18:55 -0300
Subject: [PATCH] chore: lint errors resolved

Signed-off-by: NIKUNJ LALITKUMAR HUDKA <nikunjhudka123@gmail.com>
---
 .../EntityPresentationApi.ts                  |  2 +-
 .../DefaultEntityPresentationApi.test.ts      | 12 ++---
 .../DefaultEntityPresentationApi.ts           | 46 +++++++++----------
 3 files changed, 29 insertions(+), 31 deletions(-)

diff --git a/plugins/catalog-react/src/apis/EntityPresentationApi/EntityPresentationApi.ts b/plugins/catalog-react/src/apis/EntityPresentationApi/EntityPresentationApi.ts
index de5449917a..f4f1193718 100644
--- a/plugins/catalog-react/src/apis/EntityPresentationApi/EntityPresentationApi.ts
+++ b/plugins/catalog-react/src/apis/EntityPresentationApi/EntityPresentationApi.ts
@@ -113,7 +113,7 @@ export interface EntityRefPresentation {
   /* The `promise` property in the `EntityRefPresentation` interface is defining a property named
   `promise` that holds a promise. This promise resolves to an array of
   `EntityRefPresentationSnapshot` objects. */
-  promise: Promise<EntityRefPresentationSnapshot[]>;
+  promise?: Promise<EntityRefPresentationSnapshot[]>;
 }
 
 /**
diff --git a/plugins/catalog/src/apis/EntityPresentationApi/DefaultEntityPresentationApi.test.ts b/plugins/catalog/src/apis/EntityPresentationApi/DefaultEntityPresentationApi.test.ts
index 475bfe1660..c37efb204f 100644
--- a/plugins/catalog/src/apis/EntityPresentationApi/DefaultEntityPresentationApi.test.ts
+++ b/plugins/catalog/src/apis/EntityPresentationApi/DefaultEntityPresentationApi.test.ts
@@ -35,7 +35,7 @@ describe('DefaultEntityPresentationApi', () => {
         Icon: expect.anything(),
       },
       update$: undefined,
-      promise: new Promise((resolve, reject) => resolve({})),
+      promise: new Promise(resolve => resolve({})),
     });
 
     expect(
@@ -49,7 +49,7 @@ describe('DefaultEntityPresentationApi', () => {
         Icon: expect.anything(),
       },
       update$: undefined,
-      promise: new Promise((resolve, reject) => resolve({})),
+      promise: new Promise(resolve => resolve({})),
     });
 
     expect(
@@ -65,7 +65,7 @@ describe('DefaultEntityPresentationApi', () => {
         Icon: expect.anything(),
       },
       update$: undefined,
-      promise: new Promise((resolve, reject) => resolve({})),
+      promise: new Promise(resolve => resolve({})),
     });
 
     const entity: Entity = {
@@ -88,7 +88,7 @@ describe('DefaultEntityPresentationApi', () => {
         Icon: expect.anything(),
       },
       update$: undefined,
-      promise: new Promise((resolve, reject) => resolve({})),
+      promise: new Promise(resolve => resolve({})),
     });
   });
 
@@ -192,8 +192,8 @@ describe('DefaultEntityPresentationApi', () => {
 
     const snapshots = await promise;
 
-    expect(snapshots.length).toEqual(1); // Only one snapshot expected
-    expect(snapshots[0]).toEqual(entitySnapshot); // Snapshot should match the simulated one
+    expect(snapshots?.length).toEqual(1); // Only one snapshot expected
+    expect(snapshots?.[0]).toEqual(entitySnapshot); // Snapshot should match the simulated one
   });
 });
 
diff --git a/plugins/catalog/src/apis/EntityPresentationApi/DefaultEntityPresentationApi.ts b/plugins/catalog/src/apis/EntityPresentationApi/DefaultEntityPresentationApi.ts
index bbd5540d15..c7572cca3b 100644
--- a/plugins/catalog/src/apis/EntityPresentationApi/DefaultEntityPresentationApi.ts
+++ b/plugins/catalog/src/apis/EntityPresentationApi/DefaultEntityPresentationApi.ts
@@ -302,30 +302,28 @@ export class DefaultEntityPresentationApi implements EntityPresentationApi {
       snapshot: initialSnapshot,
       update$: observable,
       get promise() {
-        return new Promise<EntityRefPresentationSnapshot[]>(
-          (resolve, reject) => {
-            if (!observable) {
-              resolve([initialSnapshot]);
-            } else {
-              const res: EntityRefPresentationSnapshot[] = [];
-              const subscription = observable.subscribe({
-                next: snapshot => {
-                  res.push(snapshot);
-                },
-                error: error => {
-                  initialSnapshot = {
-                    primaryTitle: entityRef,
-                    entityRef: entityRef,
-                  };
-                },
-                complete() {
-                  subscription.unsubscribe();
-                  resolve(res);
-                },
-              });
-            }
-          },
-        );
+        return new Promise<EntityRefPresentationSnapshot[]>(resolve => {
+          if (!observable) {
+            resolve([initialSnapshot]);
+          } else {
+            const res: EntityRefPresentationSnapshot[] = [];
+            const subscription = observable.subscribe({
+              next: snapshot => {
+                res.push(snapshot);
+              },
+              error: () => {
+                initialSnapshot = {
+                  primaryTitle: entityRef,
+                  entityRef: entityRef,
+                };
+              },
+              complete() {
+                subscription.unsubscribe();
+                resolve(res);
+              },
+            });
+          }
+        });
       },
     };
     return entityRefPresentation;