diff --git a/packages/cli/src/lib/builder/packager.test.ts b/packages/cli/src/lib/builder/packager.test.ts index 69f4b4e524..f5e101cfc6 100644 --- a/packages/cli/src/lib/builder/packager.test.ts +++ b/packages/cli/src/lib/builder/packager.test.ts @@ -23,6 +23,16 @@ describe('formatErrorMessage with esbuild plugin error', () => { plugin: 'esbuild', message: 'test', }); - expect(msg).toBe('test\n\n'); + expect(msg).toBe('test'); + }); + it('given error with errors array then error message should have new lines', () => { + const msg = formatErrorMessage({ + code: 'PLUGIN_ERROR', + plugin: 'esbuild', + message: 'test', + id: 'index.js', + errors: [{ text: 'Dummy', location: { line: 1, column: 1 } }], + }); + expect(msg).toContain('test\n\n'); }); }); diff --git a/packages/cli/src/lib/builder/packager.ts b/packages/cli/src/lib/builder/packager.ts index d6519e79a9..6deded5f69 100644 --- a/packages/cli/src/lib/builder/packager.ts +++ b/packages/cli/src/lib/builder/packager.ts @@ -27,8 +27,9 @@ export function formatErrorMessage(error: any) { if (error.code === 'PLUGIN_ERROR') { if (error.plugin === 'esbuild') { - msg += `${error.message}\n\n`; - if (error.errors) { + msg += `${error.message}`; + if (error.errors?.length) { + msg += `\n\n`; for (const { text, location } of error.errors) { const { line, column } = location; const path = relativePath(paths.targetDir, error.id);