Merge pull request #2074 from spotify/rugvip/discovery

[RFC] Add DiscoveryApi
2020-08-27 15:07:21 +02:00
parent 3fbfb42619 a21cfcd062
commit 304b7bcb13
22 changed files with 373 additions and 211 deletions
@@ -20,20 +20,13 @@ import {
  RollbarProject,
  RollbarTopActiveItem,
 } from './types';
+import { DiscoveryApi } from '@backstage/core';

 export class RollbarClient implements RollbarApi {
-  private apiOrigin: string;
-  private basePath: string;
+  private readonly discoveryApi: DiscoveryApi;

-  constructor({
-    apiOrigin,
-    basePath,
-  }: {
-    apiOrigin: string;
-    basePath: string;
-  }) {
-    this.apiOrigin = apiOrigin;
-    this.basePath = basePath;
+  constructor(options: { discoveryApi: DiscoveryApi }) {
+    this.discoveryApi = options.discoveryApi;
  }

  async getAllProjects(): Promise<RollbarProject[]> {
@@ -59,7 +52,7 @@ export class RollbarClient implements RollbarApi {
  }

  private async get(path: string): Promise<any> {
-    const url = `${this.apiOrigin}${this.basePath}${path}`;
+    const url = `${await this.discoveryApi.getBaseUrl('rollbar')}${path}`;
    const response = await fetch(url);

    if (!response.ok) {