From 2f52e74b498355b9193bb8629ed461f9f4dfea23 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= <freben@gmail.com>
Date: Fri, 2 Sep 2022 13:21:15 +0200
Subject: [PATCH] just get rid of some String
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Signed-off-by: Fredrik Adelöw <freben@gmail.com>
---
 .changeset/pink-feet-repeat.md                              | 6 ++++++
 .../backend-common/src/middleware/requestLoggingHandler.ts  | 2 +-
 .../ScheduleIntervalLabel/ScheduleIntervalLabel.tsx         | 4 ++--
 3 files changed, 9 insertions(+), 3 deletions(-)
 create mode 100644 .changeset/pink-feet-repeat.md

diff --git a/.changeset/pink-feet-repeat.md b/.changeset/pink-feet-repeat.md
new file mode 100644
index 0000000000..c4ac7560a6
--- /dev/null
+++ b/.changeset/pink-feet-repeat.md
@@ -0,0 +1,6 @@
+---
+'@backstage/backend-common': patch
+'@backstage/plugin-apache-airflow': patch
+---
+
+Got rid of usages of the uppercase String type
diff --git a/packages/backend-common/src/middleware/requestLoggingHandler.ts b/packages/backend-common/src/middleware/requestLoggingHandler.ts
index ef6be761ac..7291a1b87b 100644
--- a/packages/backend-common/src/middleware/requestLoggingHandler.ts
+++ b/packages/backend-common/src/middleware/requestLoggingHandler.ts
@@ -33,7 +33,7 @@ export function requestLoggingHandler(logger?: Logger): RequestHandler {
 
   return morgan('combined', {
     stream: {
-      write(message: String) {
+      write(message: string) {
         actualLogger.info(message.trimEnd());
       },
     },
diff --git a/plugins/apache-airflow/src/components/ScheduleIntervalLabel/ScheduleIntervalLabel.tsx b/plugins/apache-airflow/src/components/ScheduleIntervalLabel/ScheduleIntervalLabel.tsx
index 3ae72098d0..14e8148b50 100644
--- a/plugins/apache-airflow/src/components/ScheduleIntervalLabel/ScheduleIntervalLabel.tsx
+++ b/plugins/apache-airflow/src/components/ScheduleIntervalLabel/ScheduleIntervalLabel.tsx
@@ -22,7 +22,7 @@ interface Props {
   interval: ScheduleInterval | undefined;
 }
 
-const timeDeltaToLabel = (delta: TimeDelta): String => {
+const timeDeltaToLabel = (delta: TimeDelta): string => {
   let label = '';
   const date = new Date(0);
   date.setSeconds(delta.seconds);
@@ -45,7 +45,7 @@ const relativeDeltaToLabel = (delta: RelativeDelta) => {
 };
 
 export const ScheduleIntervalLabel = ({ interval }: Props) => {
-  let label: String = '';
+  let label = '';
   switch (interval?.__type) {
     case 'TimeDelta':
       label = timeDeltaToLabel(interval);