From 2f18f97f987d769c30bfc6273796d9250226ada2 Mon Sep 17 00:00:00 2001
From: Jonathan Mezach <jonathan.mezach@rr-wfm.com>
Date: Tue, 18 Apr 2023 10:40:04 +0200
Subject: [PATCH] Fix endless loop

Signed-off-by: Jonathan Mezach <jonathan.mezach@rr-wfm.com>
---
 .../EntityPageOctopusDeploy.tsx                |  6 +++---
 .../octopus-deploy/src/hooks/useReleases.ts    | 18 +++++++++++-------
 2 files changed, 14 insertions(+), 10 deletions(-)

diff --git a/plugins/octopus-deploy/src/components/EntityPageOctopusDeploy/EntityPageOctopusDeploy.tsx b/plugins/octopus-deploy/src/components/EntityPageOctopusDeploy/EntityPageOctopusDeploy.tsx
index 34ff780f70..5fc035595c 100644
--- a/plugins/octopus-deploy/src/components/EntityPageOctopusDeploy/EntityPageOctopusDeploy.tsx
+++ b/plugins/octopus-deploy/src/components/EntityPageOctopusDeploy/EntityPageOctopusDeploy.tsx
@@ -28,11 +28,11 @@ export const EntityPageOctopusDeploy = (props: { defaultLimit?: number }) => {
   const projectId = getProjectIdAnnotationFromEntity(entity);
   const spaceId = getSpaceIdAnnotationFromEntity(entity);
 
-  const { environments, releases, loading, error } = useReleases({
+  const { environments, releases, loading, error } = useReleases(
     projectId,
+    props.defaultLimit ?? 3,
     spaceId,
-    releaseHistoryCount: props.defaultLimit ?? 3,
-  });
+  );
 
   return (
     <ReleaseTable
diff --git a/plugins/octopus-deploy/src/hooks/useReleases.ts b/plugins/octopus-deploy/src/hooks/useReleases.ts
index 754d81ba43..56897ec5ed 100644
--- a/plugins/octopus-deploy/src/hooks/useReleases.ts
+++ b/plugins/octopus-deploy/src/hooks/useReleases.ts
@@ -21,11 +21,11 @@ import {
   OctopusReleaseProgression,
 } from '../api';
 
-export function useReleases(opts: {
-  projectId: string;
-  spaceId?: string;
-  releaseHistoryCount: number;
-}): {
+export function useReleases(
+  projectId: string,
+  releaseHistoryCount: number,
+  spaceId?: string,
+): {
   environments?: OctopusEnvironment[];
   releases?: OctopusReleaseProgression[];
   loading: boolean;
@@ -34,8 +34,12 @@ export function useReleases(opts: {
   const api = useApi(octopusDeployApiRef);
 
   const { value, loading, error } = useAsync(() => {
-    return api.getReleaseProgression(opts);
-  }, [api, opts]);
+    return api.getReleaseProgression({
+      projectId,
+      spaceId,
+      releaseHistoryCount,
+    });
+  }, [api, projectId, spaceId, releaseHistoryCount]);
 
   return {
     environments: value?.Environments,