From 2e701b3796cc8b0b2a476e0c8abcafedeb0eea7e Mon Sep 17 00:00:00 2001 From: Patrik Oldsberg Date: Thu, 8 Dec 2022 21:18:01 +0100 Subject: [PATCH] refactor react-router -> react-router-dom Signed-off-by: Patrik Oldsberg --- .changeset/long-eyes-confess.md | 38 +++++++++++++++++++ packages/app-defaults/package.json | 1 - packages/app/package.json | 1 - packages/app/src/App.tsx | 2 +- packages/core-components/package.json | 1 - .../src/components/Button/Button.test.tsx | 2 +- .../src/components/Link/Link.test.tsx | 2 +- .../ProgressBars/GaugeCard.stories.tsx | 2 +- .../TabbedLayout/RoutedTabs.test.tsx | 2 +- .../components/TabbedLayout/RoutedTabs.tsx | 7 +++- .../TabbedLayout/TabbedLayout.stories.tsx | 2 +- .../src/layout/ErrorPage/ErrorPage.tsx | 2 +- .../src/layout/InfoCard/InfoCard.stories.tsx | 2 +- .../src/layout/ItemCard/ItemCard.stories.tsx | 2 +- .../src/layout/Sidebar/MobileSidebar.tsx | 2 +- .../layout/TabbedCard/TabbedCard.stories.tsx | 2 +- packages/dev-utils/package.json | 1 - packages/dev-utils/src/devApp/render.tsx | 2 +- .../techdocs-cli-embedded-app/package.json | 1 - .../techdocs-cli-embedded-app/src/App.tsx | 2 +- packages/test-utils/package.json | 1 - .../src/testUtils/appWrappers.test.tsx | 2 +- .../test-utils/src/testUtils/appWrappers.tsx | 2 +- plugins/airbrake/package.json | 2 +- plugins/airbrake/src/extensions.test.tsx | 2 +- plugins/api-docs/package.json | 1 - .../ApiExplorerPage/ApiExplorerPage.test.tsx | 2 +- .../ApiExplorerPage/ApiExplorerPage.tsx | 2 +- plugins/azure-devops/package.json | 2 +- .../BuildTable/BuildTable.stories.tsx | 2 +- .../PullRequestCard.stories.tsx | 2 +- plugins/badges/package.json | 2 +- plugins/badges/src/api/BadgesClient.ts | 2 +- plugins/catalog-graph/package.json | 2 +- .../CatalogGraphCard/CatalogGraphCard.tsx | 2 +- .../CatalogGraphPage/CatalogGraphPage.tsx | 2 +- .../useCatalogGraphPage.test.ts | 2 +- .../CatalogGraphPage/useCatalogGraphPage.ts | 2 +- plugins/catalog-import/package.json | 2 +- .../components/ImportPage/ImportPage.test.tsx | 2 +- .../src/components/ImportPage/ImportPage.tsx | 2 +- plugins/catalog-react/package.json | 2 +- .../components/AncestryPage.tsx | 2 +- .../src/hooks/useEntityListProvider.test.tsx | 2 +- .../src/hooks/useEntityListProvider.tsx | 2 +- plugins/catalog/package.json | 2 +- .../CatalogEntityPage/CatalogEntityPage.tsx | 2 +- .../CatalogEntityPage/useEntityFromUrl.ts | 2 +- .../CatalogPage/CatalogPage.test.tsx | 2 +- .../components/CatalogPage/CatalogPage.tsx | 2 +- .../components/EntityLayout/EntityLayout.tsx | 2 +- .../EntityOrphanWarning.tsx | 2 +- plugins/circleci/package.json | 1 - plugins/circleci/src/components/Router.tsx | 2 +- plugins/cloudbuild/package.json | 1 - plugins/cloudbuild/src/components/Router.tsx | 2 +- plugins/code-climate/package.json | 2 +- plugins/code-coverage/package.json | 1 - plugins/explore/package.json | 1 - .../ExplorePage/ExplorePage.test.tsx | 2 +- .../components/ExplorePage/ExplorePage.tsx | 2 +- plugins/git-release-manager/package.json | 2 +- .../src/features/RepoDetailsForm/Owner.tsx | 2 +- .../src/features/RepoDetailsForm/Repo.tsx | 2 +- .../RepoDetailsForm/VersioningStrategy.tsx | 2 +- .../src/hooks/useQueryHandler.ts | 2 +- plugins/github-actions/package.json | 1 - .../github-actions/src/components/Router.tsx | 2 +- plugins/home/package.json | 2 +- .../components/HomepageCompositionRoot.tsx | 2 +- plugins/jenkins/package.json | 1 - plugins/jenkins/src/components/Router.tsx | 2 +- plugins/kafka/package.json | 2 +- plugins/kafka/src/Router.tsx | 2 +- plugins/org/package.json | 1 - .../MembersList/MembersListCard.stories.tsx | 2 +- plugins/permission-react/package.json | 2 +- .../src/components/PermissionedRoute.tsx | 2 +- plugins/playlist/package.json | 1 - .../playlist/src/components/Router/Router.tsx | 2 +- .../src/hooks/usePlaylistList.test.tsx | 2 +- .../playlist/src/hooks/usePlaylistList.tsx | 2 +- plugins/rollbar/package.json | 1 - plugins/rollbar/src/components/Router.tsx | 2 +- plugins/scaffolder/package.json | 1 - plugins/scaffolder/src/components/Router.tsx | 2 +- .../ScaffolderPageContextMenu.tsx | 2 +- .../src/components/TaskPage/TaskPage.tsx | 2 +- .../TemplatePage/TemplatePage.test.tsx | 2 +- .../components/TemplatePage/TemplatePage.tsx | 2 +- plugins/scaffolder/src/next/Router/Router.tsx | 2 +- .../TemplateWizardPage/TemplateWizardPage.tsx | 2 +- plugins/search-react/package.json | 2 +- .../DefaultResultListItem.stories.tsx | 2 +- .../SearchResult/SearchResult.stories.tsx | 2 +- plugins/search/package.json | 1 - .../components/SearchPage/SearchPage.test.tsx | 2 +- .../src/components/SearchPage/SearchPage.tsx | 2 +- plugins/sentry/package.json | 2 +- plugins/sentry/src/components/Router.tsx | 2 +- plugins/shortcuts/package.json | 2 +- plugins/shortcuts/src/AddShortcut.tsx | 2 +- plugins/techdocs/package.json | 2 +- .../components/TechDocsIndexPage.test.tsx | 2 +- .../src/home/components/TechDocsIndexPage.tsx | 2 +- .../src/search/components/TechDocsSearch.tsx | 2 +- plugins/todo/package.json | 2 +- plugins/todo/src/plugin.test.tsx | 2 +- plugins/user-settings/package.json | 2 +- .../DefaultSettingsPage.test.tsx | 2 +- .../SettingsPage/SettingsPage.test.tsx | 2 +- .../components/SettingsPage/SettingsPage.tsx | 2 +- 112 files changed, 136 insertions(+), 111 deletions(-) create mode 100644 .changeset/long-eyes-confess.md diff --git a/.changeset/long-eyes-confess.md b/.changeset/long-eyes-confess.md new file mode 100644 index 0000000000..f35504f8d7 --- /dev/null +++ b/.changeset/long-eyes-confess.md @@ -0,0 +1,38 @@ +--- +'@backstage/app-defaults': patch +'@backstage/core-components': patch +'@backstage/dev-utils': patch +'@backstage/test-utils': patch +'@backstage/plugin-airbrake': patch +'@backstage/plugin-api-docs': patch +'@backstage/plugin-azure-devops': patch +'@backstage/plugin-badges': patch +'@backstage/plugin-catalog': patch +'@backstage/plugin-catalog-graph': patch +'@backstage/plugin-catalog-import': patch +'@backstage/plugin-catalog-react': patch +'@backstage/plugin-circleci': patch +'@backstage/plugin-cloudbuild': patch +'@backstage/plugin-code-climate': patch +'@backstage/plugin-code-coverage': patch +'@backstage/plugin-explore': patch +'@backstage/plugin-git-release-manager': patch +'@backstage/plugin-github-actions': patch +'@backstage/plugin-home': patch +'@backstage/plugin-jenkins': patch +'@backstage/plugin-kafka': patch +'@backstage/plugin-org': patch +'@backstage/plugin-permission-react': patch +'@backstage/plugin-playlist': patch +'@backstage/plugin-rollbar': patch +'@backstage/plugin-scaffolder': patch +'@backstage/plugin-search': patch +'@backstage/plugin-search-react': patch +'@backstage/plugin-sentry': patch +'@backstage/plugin-shortcuts': patch +'@backstage/plugin-techdocs': patch +'@backstage/plugin-todo': patch +'@backstage/plugin-user-settings': patch +--- + +Internal refactor to use `react-router-dom` rather than `react-router`. diff --git a/packages/app-defaults/package.json b/packages/app-defaults/package.json index 5b8e4da681..61eac23cc6 100644 --- a/packages/app-defaults/package.json +++ b/packages/app-defaults/package.json @@ -43,7 +43,6 @@ "peerDependencies": { "react": "^16.13.1 || ^17.0.0", "react-dom": "^16.13.1 || ^17.0.0", - "react-router": "6.0.0-beta.0 || ^6.3.0", "react-router-dom": "6.0.0-beta.0 || ^6.3.0" }, "devDependencies": { diff --git a/packages/app/package.json b/packages/app/package.json index e953838a2f..b7b75f83c2 100644 --- a/packages/app/package.json +++ b/packages/app/package.json @@ -77,7 +77,6 @@ "prop-types": "^15.7.2", "react": "^17.0.2", "react-dom": "^17.0.2", - "react-router": "^6.3.0", "react-router-dom": "^6.3.0", "react-use": "^17.2.4", "zen-observable": "^0.10.0" diff --git a/packages/app/src/App.tsx b/packages/app/src/App.tsx index 05ef61c11a..23bacfceec 100644 --- a/packages/app/src/App.tsx +++ b/packages/app/src/App.tsx @@ -86,7 +86,7 @@ import { import { AdvancedSettings } from './components/advancedSettings'; import AlarmIcon from '@material-ui/icons/Alarm'; import React from 'react'; -import { Navigate, Route } from 'react-router'; +import { Navigate, Route } from 'react-router-dom'; import { apis } from './apis'; import { entityPage } from './components/catalog/EntityPage'; import { homePage } from './components/home/HomePage'; diff --git a/packages/core-components/package.json b/packages/core-components/package.json index dc2bc08093..4a028e9dc3 100644 --- a/packages/core-components/package.json +++ b/packages/core-components/package.json @@ -74,7 +74,6 @@ "@types/react": "^16.13.1 || ^17.0.0", "react": "^16.13.1 || ^17.0.0", "react-dom": "^16.13.1 || ^17.0.0", - "react-router": "6.0.0-beta.0 || ^6.3.0", "react-router-dom": "6.0.0-beta.0 || ^6.3.0" }, "devDependencies": { diff --git a/packages/core-components/src/components/Button/Button.test.tsx b/packages/core-components/src/components/Button/Button.test.tsx index 805b3b3f10..c5942e3d78 100644 --- a/packages/core-components/src/components/Button/Button.test.tsx +++ b/packages/core-components/src/components/Button/Button.test.tsx @@ -18,7 +18,7 @@ import React from 'react'; import { render, fireEvent, act } from '@testing-library/react'; import { wrapInTestApp } from '@backstage/test-utils'; import { Button } from './Button'; -import { Route, Routes } from 'react-router'; +import { Route, Routes } from 'react-router-dom'; describe('