From 741e84d827b56f5e17659aa3de41c32e89a4adcf Mon Sep 17 00:00:00 2001 From: kallayj <118477617+kallayj@users.noreply.github.com> Date: Tue, 23 May 2023 10:29:30 -0700 Subject: [PATCH 1/2] Fixes the example config in HostDiscovery.ts. The permission plugin was referenced as 'permissions' when the plugin id is 'permission'. Signed-off-by: Jonathan Kallay --- packages/backend-common/src/discovery/HostDiscovery.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/backend-common/src/discovery/HostDiscovery.ts b/packages/backend-common/src/discovery/HostDiscovery.ts index abac4413be..1c72445443 100644 --- a/packages/backend-common/src/discovery/HostDiscovery.ts +++ b/packages/backend-common/src/discovery/HostDiscovery.ts @@ -45,7 +45,7 @@ export class HostDiscovery implements PluginEndpointDiscovery { * - target: https://internal.example.com/internal-catalog * plugins: [catalog] * - target: https://internal.example.com/secure/api/{{pluginId}} - * plugins: [auth, permissions] + * plugins: [auth, permission] * - target: * internal: https://internal.example.com/search * external: https://example.com/search From 9f47a743632ca764d17550abbd756f3d8e886768 Mon Sep 17 00:00:00 2001 From: kallayj <118477617+kallayj@users.noreply.github.com> Date: Wed, 24 May 2023 22:00:16 +0000 Subject: [PATCH 2/2] Added changeset Signed-off-by: Jonathan Kallay --- .changeset/nice-readers-heal.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/nice-readers-heal.md diff --git a/.changeset/nice-readers-heal.md b/.changeset/nice-readers-heal.md new file mode 100644 index 0000000000..54534f8289 --- /dev/null +++ b/.changeset/nice-readers-heal.md @@ -0,0 +1,5 @@ +--- +'@backstage/backend-common': patch +--- + +Fixed typo in HostDiscovery's JSDoc