From 2e0adeb664c7c828e0390f221b022a0cdf080d94 Mon Sep 17 00:00:00 2001 From: Eric Peterson Date: Sun, 5 Sep 2021 21:38:00 +0200 Subject: [PATCH] Self-review Signed-off-by: Eric Peterson --- packages/core-components/src/components/Link/Link.test.tsx | 2 +- packages/core-components/src/components/Link/Link.tsx | 2 -- plugins/search/src/components/SearchPage/SearchPage.test.tsx | 2 +- 3 files changed, 2 insertions(+), 4 deletions(-) diff --git a/packages/core-components/src/components/Link/Link.test.tsx b/packages/core-components/src/components/Link/Link.test.tsx index 0be4749f0a..504de6bb9a 100644 --- a/packages/core-components/src/components/Link/Link.test.tsx +++ b/packages/core-components/src/components/Link/Link.test.tsx @@ -18,10 +18,10 @@ import React from 'react'; import { render, fireEvent } from '@testing-library/react'; import { MockAnalyticsApi, wrapInTestApp } from '@backstage/test-utils'; import { ApiProvider, ApiRegistry } from '@backstage/core-app-api'; +import { analyticsApiRef } from '@backstage/core-plugin-api'; import { isExternalUri, Link } from './Link'; import { Route, Routes } from 'react-router'; import { act } from 'react-dom/test-utils'; -import { analyticsApiRef } from '../../../../core-plugin-api/src'; describe('', () => { it('navigates using react-router', async () => { diff --git a/packages/core-components/src/components/Link/Link.tsx b/packages/core-components/src/components/Link/Link.tsx index b985fcb922..7b26ea5037 100644 --- a/packages/core-components/src/components/Link/Link.tsx +++ b/packages/core-components/src/components/Link/Link.tsx @@ -37,8 +37,6 @@ export type LinkProps = MaterialLinkProps & declare function LinkType(props: LinkProps): JSX.Element; /** - * Thin wrapper on top of material-ui's Link component - * Makes the Link to utilise react-router * Thin wrapper on top of material-ui's Link component, which... * - Makes the Link use react-router * - Captures Link clicks as analytics events. diff --git a/plugins/search/src/components/SearchPage/SearchPage.test.tsx b/plugins/search/src/components/SearchPage/SearchPage.test.tsx index bc3b8ceb0b..c9980b3bf7 100644 --- a/plugins/search/src/components/SearchPage/SearchPage.test.tsx +++ b/plugins/search/src/components/SearchPage/SearchPage.test.tsx @@ -75,7 +75,7 @@ describe('SearchPage', () => { const expectedFilters = { [expectedFilterField]: expectedFilterValue }; const expectedPageCursor = 'SOMEPAGE'; - // e.g. ?query=petstore&pageCursor=1&filters[lifecycle][]=experimental&filters[kind]=Component + // e.g. ?query=petstore&pageCursor=SOMEPAGE&filters[lifecycle][]=experimental&filters[kind]=Component (useLocation as jest.Mock).mockReturnValue({ search: `?query=${expectedTerm}&types[]=${expectedTypes[0]}&filters[${expectedFilterField}]=${expectedFilterValue}&pageCursor=${expectedPageCursor}`, });