From 2debe758f11c59744bbc60fa42af4284ee685ff2 Mon Sep 17 00:00:00 2001
From: Eric Peterson <ericpeterson@spotify.com>
Date: Thu, 23 Sep 2021 12:09:54 +0200
Subject: [PATCH] Fix plugin handling on gathered mount points and document
 logic.

Signed-off-by: Eric Peterson <ericpeterson@spotify.com>
---
 .../core-app-api/src/routing/RouteTracker.tsx    | 16 ++++++++++++----
 packages/core-app-api/src/routing/collectors.tsx |  1 +
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/packages/core-app-api/src/routing/RouteTracker.tsx b/packages/core-app-api/src/routing/RouteTracker.tsx
index f53a6fa1e8..f65ef49dec 100644
--- a/packages/core-app-api/src/routing/RouteTracker.tsx
+++ b/packages/core-app-api/src/routing/RouteTracker.tsx
@@ -39,25 +39,33 @@ const getExtensionContext = (
   routes: BackstageRouteObject[],
 ): CommonAnalyticsContext | {} => {
   try {
+    // Find matching routes for the given path name.
     const matches = matchRoutes(routes, { pathname });
+
+    // Of the matching routes, get the last (e.g. most specific) instance of
+    // the BackstageRouteObject.
     const routeObject = matches
       ?.filter(
         match => (match?.route as BackstageRouteObject).routeRefs?.size > 0,
       )
       .pop()?.route as BackstageRouteObject;
 
+    // If there is no route object, then allow inheritance of default context.
     if (!routeObject) {
       return {};
     }
 
-    const routeRef = routeObject.routeRefs.values().next().value as
-      | RouteRef
-      | undefined;
+    // If there is a single route ref, return it.
+    // todo: get routeRef of rendered gathered mount point(?)
+    let routeRef: RouteRef | undefined;
+    if (routeObject.routeRefs.size === 1) {
+      routeRef = routeObject.routeRefs.values().next().value;
+    }
 
     return {
       extension: 'App',
       pluginId: routeObject.plugin?.getId() || 'root',
-      routeRef: (routeRef as { id?: string }).id,
+      ...(routeRef ? { routeRef: (routeRef as { id?: string }).id } : {}),
     };
   } catch {
     return {};
diff --git a/packages/core-app-api/src/routing/collectors.tsx b/packages/core-app-api/src/routing/collectors.tsx
index 2d044b4b23..320f1a66d8 100644
--- a/packages/core-app-api/src/routing/collectors.tsx
+++ b/packages/core-app-api/src/routing/collectors.tsx
@@ -171,6 +171,7 @@ export const routeObjectCollector = createCollector(
         element: 'gathered',
         routeRefs: new Set(),
         children: [MATCH_ALL_ROUTE],
+        plugin: parentObj?.plugin,
       };
       parentChildren.push(newObject);
       return newObject;