From 9977dea42a2f21be736c03306a2f75d6c147db2e Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 11 Jan 2021 14:13:37 -0500 Subject: [PATCH 1/3] Tweak proxy instructions --- plugins/sonarqube/README.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/sonarqube/README.md b/plugins/sonarqube/README.md index 28bf196ea5..87fd7f33b7 100644 --- a/plugins/sonarqube/README.md +++ b/plugins/sonarqube/README.md @@ -42,13 +42,15 @@ const OverviewContent = ({ entity }: { entity: Entity }) => ( 4. Add the proxy config: + Provide a method for your Backstage backend to get to your SonarQube API end point. + **SonarCloud** ```yaml # app-config.yaml proxy: - '/sonarqube': + '/sonarqube/api': target: https://sonarcloud.io/api allowedMethods: ['GET'] headers: @@ -64,7 +66,7 @@ proxy: # app-config.yaml proxy: - '/sonarqube': + '/sonarqube/api': target: https://your.sonarqube.instance.com/api allowedMethods: ['GET'] headers: From 39824e2e0798eee7aaac5acbe8ae94e1ae872b79 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 11 Jan 2021 14:22:02 -0500 Subject: [PATCH 2/3] Returns proxy definition --- plugins/sonarqube/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/sonarqube/README.md b/plugins/sonarqube/README.md index 87fd7f33b7..93fb2e4003 100644 --- a/plugins/sonarqube/README.md +++ b/plugins/sonarqube/README.md @@ -50,7 +50,7 @@ const OverviewContent = ({ entity }: { entity: Entity }) => ( # app-config.yaml proxy: - '/sonarqube/api': + '/sonarqube': target: https://sonarcloud.io/api allowedMethods: ['GET'] headers: @@ -66,7 +66,7 @@ proxy: # app-config.yaml proxy: - '/sonarqube/api': + '/sonarqube': target: https://your.sonarqube.instance.com/api allowedMethods: ['GET'] headers: From 5c83fd0805ed1d61a7b028e583bb05d806c21c36 Mon Sep 17 00:00:00 2001 From: Adam Harvey Date: Mon, 11 Jan 2021 14:30:04 -0500 Subject: [PATCH 3/3] Column alignment (prettier) --- plugins/sonarqube/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugins/sonarqube/README.md b/plugins/sonarqube/README.md index 93fb2e4003..7afc9cc04a 100644 --- a/plugins/sonarqube/README.md +++ b/plugins/sonarqube/README.md @@ -42,7 +42,7 @@ const OverviewContent = ({ entity }: { entity: Entity }) => ( 4. Add the proxy config: - Provide a method for your Backstage backend to get to your SonarQube API end point. + Provide a method for your Backstage backend to get to your SonarQube API end point. **SonarCloud**