From 2be88bdcc08567370ee464c5de398a89d061e43b Mon Sep 17 00:00:00 2001 From: Nikunj Hudka Date: Sun, 23 Feb 2025 23:02:38 -0400 Subject: [PATCH] feat: ui:disabled allowed in DefaultRepoBranchPicker Signed-off-by: Nikunj Hudka --- .../DefaultRepoBranchPicker.test.tsx | 19 ++++++++++++++++++- .../DefaultRepoBranchPicker.tsx | 2 ++ 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/plugins/scaffolder/src/components/fields/RepoBranchPicker/DefaultRepoBranchPicker.test.tsx b/plugins/scaffolder/src/components/fields/RepoBranchPicker/DefaultRepoBranchPicker.test.tsx index 77589e4478..952260ec81 100644 --- a/plugins/scaffolder/src/components/fields/RepoBranchPicker/DefaultRepoBranchPicker.test.tsx +++ b/plugins/scaffolder/src/components/fields/RepoBranchPicker/DefaultRepoBranchPicker.test.tsx @@ -15,7 +15,7 @@ */ import React from 'react'; -import { fireEvent, render } from '@testing-library/react'; +import { fireEvent, render, screen } from '@testing-library/react'; import { DefaultRepoBranchPicker } from './DefaultRepoBranchPicker'; @@ -33,6 +33,23 @@ describe('DefaultRepoBranchPicker', () => { expect(getByRole('textbox')).toHaveValue('main'); }); + it('input field disabled', () => { + render( + , + ); + + const input = screen.getByRole('textbox'); + + // Expect input to be disabled + expect(input).toBeDisabled(); + expect(input).toHaveValue('main'); + }); + it('calls onChange when the input field changes', () => { const onChange = jest.fn(); diff --git a/plugins/scaffolder/src/components/fields/RepoBranchPicker/DefaultRepoBranchPicker.tsx b/plugins/scaffolder/src/components/fields/RepoBranchPicker/DefaultRepoBranchPicker.tsx index 0fecfb7947..b06bdfa50c 100644 --- a/plugins/scaffolder/src/components/fields/RepoBranchPicker/DefaultRepoBranchPicker.tsx +++ b/plugins/scaffolder/src/components/fields/RepoBranchPicker/DefaultRepoBranchPicker.tsx @@ -32,6 +32,7 @@ export const DefaultRepoBranchPicker = ({ onChange, state, rawErrors, + isDisabled, required, }: BaseRepoBranchPickerProps) => { const { branch } = state; @@ -45,6 +46,7 @@ export const DefaultRepoBranchPicker = ({ onChange({ branch: e.target.value })} value={branch} />