From 2bdd1f92c15b224f119a10bd1d428e2b3168a9ee Mon Sep 17 00:00:00 2001 From: Carlos Esteban Lopez Date: Tue, 3 Jan 2023 12:43:54 -0500 Subject: [PATCH] fix: Add paragraph prop for bottom margin Signed-off-by: Carlos Esteban Lopez --- .../src/layout/Breadcrumbs/Breadcrumbs.stories.tsx | 10 +++++----- .../EntityBazaarInfoContent.tsx | 2 +- .../HomePageBazaarInfoCard/HomePageBazaarInfoCard.tsx | 2 +- plugins/fossa/src/components/FossaCard/FossaCard.tsx | 5 +++-- .../components/WorkflowRunsTable/WorkflowRunsTable.tsx | 8 ++++++-- .../home/src/homePageComponents/RandomJoke/Content.tsx | 6 +++--- .../src/components/BuildsPage/lib/CITable/CITable.tsx | 6 +++--- .../CustomResources/ArgoRollouts/StepsProgress.tsx | 4 ++-- .../ListTasksPage/columns/CreatedAtColumn.tsx | 4 +++- .../ListTasksPage/columns/OwnerEntityColumn.tsx | 2 +- .../src/home/StackOverflowQuestions/Content.tsx | 4 ++-- .../src/components/RadarLegend/RadarLegendRing.tsx | 4 +++- plugins/tech-radar/src/components/RadarPage.tsx | 2 +- .../src/components/BuildTimeline/BuildTimeline.tsx | 2 +- 14 files changed, 35 insertions(+), 26 deletions(-) diff --git a/packages/core-components/src/layout/Breadcrumbs/Breadcrumbs.stories.tsx b/packages/core-components/src/layout/Breadcrumbs/Breadcrumbs.stories.tsx index 00563be313..04363f2a4a 100644 --- a/packages/core-components/src/layout/Breadcrumbs/Breadcrumbs.stories.tsx +++ b/packages/core-components/src/layout/Breadcrumbs/Breadcrumbs.stories.tsx @@ -36,7 +36,7 @@ export default { export const InHeader = () => (

Standard breadcrumbs

- + Underlined pages are links. This should show a hierarchical relationship. @@ -61,14 +61,14 @@ export const OutsideOfHeader = () => { const open = Boolean(anchorEl); return ( - + It might be the case that you want to keep your breadcrumbs outside of the header. In that case, they should be positioned above the title of the page.

Standard breadcrumbs

- + Underlined pages are links. This should show a hierarchical relationship. @@ -82,7 +82,7 @@ export const OutsideOfHeader = () => {

Hidden breadcrumbs

- + Use this when you have more than three breadcrumbs. When user clicks on ellipses, expand the breadcrumbs out. @@ -96,7 +96,7 @@ export const OutsideOfHeader = () => {

Layered breadcrumbs

- + Use this when you want to show alternative breadcrumbs on the same hierarchical level. diff --git a/plugins/bazaar/src/components/EntityBazaarInfoContent/EntityBazaarInfoContent.tsx b/plugins/bazaar/src/components/EntityBazaarInfoContent/EntityBazaarInfoContent.tsx index 9bb1bfae8f..e0a3a9b881 100644 --- a/plugins/bazaar/src/components/EntityBazaarInfoContent/EntityBazaarInfoContent.tsx +++ b/plugins/bazaar/src/components/EntityBazaarInfoContent/EntityBazaarInfoContent.tsx @@ -184,7 +184,7 @@ export const EntityBazaarInfoContent = ({ + {bazaarProject?.title!} } diff --git a/plugins/bazaar/src/components/HomePageBazaarInfoCard/HomePageBazaarInfoCard.tsx b/plugins/bazaar/src/components/HomePageBazaarInfoCard/HomePageBazaarInfoCard.tsx index 183fcd5f52..7c6491c8a5 100644 --- a/plugins/bazaar/src/components/HomePageBazaarInfoCard/HomePageBazaarInfoCard.tsx +++ b/plugins/bazaar/src/components/HomePageBazaarInfoCard/HomePageBazaarInfoCard.tsx @@ -257,7 +257,7 @@ export const HomePageBazaarInfoCard = ({ + {bazaarProject.value?.title || initProject.title} } diff --git a/plugins/fossa/src/components/FossaCard/FossaCard.tsx b/plugins/fossa/src/components/FossaCard/FossaCard.tsx index 28780d7b88..8aa3d18157 100644 --- a/plugins/fossa/src/components/FossaCard/FossaCard.tsx +++ b/plugins/fossa/src/components/FossaCard/FossaCard.tsx @@ -167,6 +167,7 @@ export const FossaCard = (props: { variant?: InfoCardVariants }) => { > 0 || value.dependencyCount === 0 ? classes.numberError @@ -176,12 +177,12 @@ export const FossaCard = (props: { variant?: InfoCardVariants }) => { {value.issueCount} {value.dependencyCount > 0 && ( - + Number of issues )} {value.dependencyCount === 0 && ( - + No Dependencies.
Please check your FOSSA project settings. diff --git a/plugins/github-actions/src/components/WorkflowRunsTable/WorkflowRunsTable.tsx b/plugins/github-actions/src/components/WorkflowRunsTable/WorkflowRunsTable.tsx index 150619a799..f05a41e71b 100644 --- a/plugins/github-actions/src/components/WorkflowRunsTable/WorkflowRunsTable.tsx +++ b/plugins/github-actions/src/components/WorkflowRunsTable/WorkflowRunsTable.tsx @@ -68,8 +68,12 @@ const generatedColumns: TableColumn[] = [ title: 'Source', render: (row: Partial) => ( - {row.source?.branchName} - {row.source?.commit.hash} + + {row.source?.branchName} + + + {row.source?.commit.hash} + ), }, diff --git a/plugins/home/src/homePageComponents/RandomJoke/Content.tsx b/plugins/home/src/homePageComponents/RandomJoke/Content.tsx index 215a880024..80467c46fa 100644 --- a/plugins/home/src/homePageComponents/RandomJoke/Content.tsx +++ b/plugins/home/src/homePageComponents/RandomJoke/Content.tsx @@ -21,12 +21,12 @@ import { useRandomJoke } from './Context'; export const Content = () => { const { joke, loading } = useRandomJoke(); - if (loading) return Loading...; + if (loading) return Loading...; return (
- {joke.setup} - {joke.punchline} + {joke.setup} + {joke.punchline}
); }; diff --git a/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx b/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx index a35b5b42c7..0217f00513 100644 --- a/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx +++ b/plugins/jenkins/src/components/BuildsPage/lib/CITable/CITable.tsx @@ -126,12 +126,12 @@ const generatedColumns: TableColumn[] = [ field: 'lastBuild.source.branchName', render: (row: Partial) => ( <> - + {row.lastBuild?.source?.branchName} - {row.lastBuild?.source?.commit?.hash} + {row.lastBuild?.source?.commit?.hash} ), }, @@ -152,7 +152,7 @@ const generatedColumns: TableColumn[] = [ render: (row: Partial) => { return ( <> - + {row.lastBuild?.tests && ( {row.lastBuild?.tests.passed} / {row.lastBuild?.tests.total}{' '} diff --git a/plugins/kubernetes/src/components/CustomResources/ArgoRollouts/StepsProgress.tsx b/plugins/kubernetes/src/components/CustomResources/ArgoRollouts/StepsProgress.tsx index fe4345fbbb..c93ab41d1d 100644 --- a/plugins/kubernetes/src/components/CustomResources/ArgoRollouts/StepsProgress.tsx +++ b/plugins/kubernetes/src/components/CustomResources/ArgoRollouts/StepsProgress.tsx @@ -50,9 +50,9 @@ const createLabelForStep = (step: ArgoRolloutCanaryStep): React.ReactNode => { } else if (isAnalysisStep(step)) { return (
- analysis templates: + analysis templates: {step.analysis.templates.map((t, i) => ( - {`${t.templateName}${ + {`${t.templateName}${ t.clusterScope ? ' (cluster scoped)' : '' }`} ))} diff --git a/plugins/scaffolder/src/components/ListTasksPage/columns/CreatedAtColumn.tsx b/plugins/scaffolder/src/components/ListTasksPage/columns/CreatedAtColumn.tsx index 05d479eaf0..3b47287fd6 100644 --- a/plugins/scaffolder/src/components/ListTasksPage/columns/CreatedAtColumn.tsx +++ b/plugins/scaffolder/src/components/ListTasksPage/columns/CreatedAtColumn.tsx @@ -25,6 +25,8 @@ export const CreatedAtColumn = ({ createdAt }: { createdAt: string }) => { .valueOf(); return ( - {humanizeDuration(formatted, { round: true })} ago + + {humanizeDuration(formatted, { round: true })} ago + ); }; diff --git a/plugins/scaffolder/src/components/ListTasksPage/columns/OwnerEntityColumn.tsx b/plugins/scaffolder/src/components/ListTasksPage/columns/OwnerEntityColumn.tsx index 375e8d44e9..b89141392c 100644 --- a/plugins/scaffolder/src/components/ListTasksPage/columns/OwnerEntityColumn.tsx +++ b/plugins/scaffolder/src/components/ListTasksPage/columns/OwnerEntityColumn.tsx @@ -31,7 +31,7 @@ export const OwnerEntityColumn = ({ entityRef }: { entityRef?: string }) => { ); if (!entityRef) { - return Unknown; + return Unknown; } if (loading || error) { diff --git a/plugins/stack-overflow/src/home/StackOverflowQuestions/Content.tsx b/plugins/stack-overflow/src/home/StackOverflowQuestions/Content.tsx index f277f8425e..8fce24bd22 100644 --- a/plugins/stack-overflow/src/home/StackOverflowQuestions/Content.tsx +++ b/plugins/stack-overflow/src/home/StackOverflowQuestions/Content.tsx @@ -52,11 +52,11 @@ export const Content = (props: StackOverflowQuestionsContentProps) => { }, []); if (loading) { - return loading...; + return loading...; } if (error || !value || !value.length) { - return could not load questions; + return could not load questions; } const getSecondaryText = (answer_count: Number) => diff --git a/plugins/tech-radar/src/components/RadarLegend/RadarLegendRing.tsx b/plugins/tech-radar/src/components/RadarLegend/RadarLegendRing.tsx index 78232a3a88..09badecdcd 100644 --- a/plugins/tech-radar/src/components/RadarLegend/RadarLegendRing.tsx +++ b/plugins/tech-radar/src/components/RadarLegend/RadarLegendRing.tsx @@ -39,7 +39,9 @@ export const RadarLegendRing = ({

{ring.name}

{entries.length === 0 ? ( - (empty) + + (empty) + ) : (
    {entries.map(entry => ( diff --git a/plugins/tech-radar/src/components/RadarPage.tsx b/plugins/tech-radar/src/components/RadarPage.tsx index 03f33f9e4c..802acef2a8 100644 --- a/plugins/tech-radar/src/components/RadarPage.tsx +++ b/plugins/tech-radar/src/components/RadarPage.tsx @@ -80,7 +80,7 @@ export function RadarPage(props: TechRadarPageProps) { onChange={e => setSearchText(e.target.value)} /> - + This is used for visualizing the official guidelines of different areas of software development such as languages, frameworks, infrastructure and processes. You can find an explanation for the diff --git a/plugins/xcmetrics/src/components/BuildTimeline/BuildTimeline.tsx b/plugins/xcmetrics/src/components/BuildTimeline/BuildTimeline.tsx index 83c8288388..54d84ff6c6 100644 --- a/plugins/xcmetrics/src/components/BuildTimeline/BuildTimeline.tsx +++ b/plugins/xcmetrics/src/components/BuildTimeline/BuildTimeline.tsx @@ -92,7 +92,7 @@ export const BuildTimeline = ({ width, }: BuildTimelineProps) => { const theme = useTheme(); - if (!targets.length) return No Targets; + if (!targets.length) return No Targets; const data = getTimelineData(targets);