chore: remove action read scaffolder permission

Signed-off-by: Frank Kong <frkong@redhat.com>

plugins/scaffolder-common/src/permissions.ts

@@ -42,19 +42,6 @@ export const actionExecutePermission = createPermission({
   resourceType: RESOURCE_TYPE_SCAFFOLDER_ACTION,
 });
 
-// TODO: Figure out whether to convert this to a basic permission or remove it completely since the current rules aren't applicable to this permission
-/**
- * This permission is used to authorize actions that involve access the action registry
- *
- * @alpha
- */
-export const actionReadPermission = createPermission({
-  name: 'scaffolder.action.read',
-  attributes: {
-    action: 'read',
-  },
-  resourceType: RESOURCE_TYPE_SCAFFOLDER_ACTION,
-});
 /**
  * This permission is used to authorize actions that involve reading
  * one or more parameters from a template.
@@ -126,15 +113,6 @@ export const taskCancelPermission = createPermission({
   attributes: {},
 });
 
-/**
- * List of all the scaffolder permissions
- * @alpha
- */
-export const scaffolderPermissions = [
-  templateParameterReadPermission,
-  templateStepReadPermission,
-];
-
 /**
  * List of the scaffolder permissions that are associated with template steps and parameters.
  * @alpha
@@ -148,10 +126,7 @@ export const scaffolderTemplatePermissions = [
  * List of the scaffolder permissions that are associated with scaffolder actions.
  * @alpha
  */
-export const scaffolderActionPermissions = [
-  actionExecutePermission,
-  actionReadPermission,
-];
+export const scaffolderActionPermissions = [actionExecutePermission];
 
 /**
  * List of the scaffolder permissions that are associated with scaffolder tasks.
@@ -162,3 +137,13 @@ export const scaffolderTaskPermissions = [
   taskCreatePermission,
   taskReadPermission,
 ];
+
+/**
+ * List of all the scaffolder permissions
+ * @alpha
+ */
+export const scaffolderPermissions = [
+  ...scaffolderTemplatePermissions,
+  ...scaffolderActionPermissions,
+  ...scaffolderTaskPermissions,
+];