From 2ba6e22d9bdfea19763780379992296d97092a5c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fredrik=20Adel=C3=B6w?= Date: Sun, 22 Feb 2026 15:37:58 +0100 Subject: [PATCH] address review comments MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Fredrik Adelöw --- packages/catalog-client/src/types/api.ts | 2 +- packages/catalog-client/src/types/discovery.ts | 4 +++- packages/catalog-client/src/types/fetch.ts | 4 +++- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/catalog-client/src/types/api.ts b/packages/catalog-client/src/types/api.ts index c27e61bf22..c766b094b8 100644 --- a/packages/catalog-client/src/types/api.ts +++ b/packages/catalog-client/src/types/api.ts @@ -546,7 +546,7 @@ export interface CatalogApi { * * The output list of entities is of the same size and in the same order as * the requested list of entity refs. Entries that are not found are returned - * as null. + * as undefined. * * @param request - Request parameters * @param options - Additional options diff --git a/packages/catalog-client/src/types/discovery.ts b/packages/catalog-client/src/types/discovery.ts index ca1177c7ed..3755e0d529 100644 --- a/packages/catalog-client/src/types/discovery.ts +++ b/packages/catalog-client/src/types/discovery.ts @@ -15,7 +15,9 @@ */ /** - * This is a polymorphic version of `DiscoveryApi` / `DiscoveryService`. + * This is a structurally similar version of `DiscoveryApi` / + * `DiscoveryService`, used here to avoid dependencies on the frontend or + * backend plugin API packages and allowing both of those forms to be passed in. */ export type DiscoveryApi = { getBaseUrl(pluginId: string): Promise; diff --git a/packages/catalog-client/src/types/fetch.ts b/packages/catalog-client/src/types/fetch.ts index 81facdbac0..a99140b749 100644 --- a/packages/catalog-client/src/types/fetch.ts +++ b/packages/catalog-client/src/types/fetch.ts @@ -15,7 +15,9 @@ */ /** - * This is a polymorphic version of `FetchApi`. + * This is a structurally similar version of `FetchApi`, used here to avoid + * dependencies on the frontend or backend plugin API packages and allowing both + * of those forms to be passed in. */ export type FetchApi = { fetch: typeof fetch;