From ae7d42696ee80195e3c0b925e35aa820c91430d1 Mon Sep 17 00:00:00 2001 From: mario ma Date: Wed, 11 Jun 2025 16:36:25 +0800 Subject: [PATCH 1/2] fix: update about card links style for pretty display with other language Signed-off-by: mario ma --- .changeset/young-doodles-enter.md | 5 +++++ .../src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 .changeset/young-doodles-enter.md diff --git a/.changeset/young-doodles-enter.md b/.changeset/young-doodles-enter.md new file mode 100644 index 0000000000..63e1f33eda --- /dev/null +++ b/.changeset/young-doodles-enter.md @@ -0,0 +1,5 @@ +--- +'@backstage/core-components': patch +--- + +update about card links style for pretty display with other language diff --git a/packages/core-components/src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx b/packages/core-components/src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx index 1fcf664bab..3c46e6ba27 100644 --- a/packages/core-components/src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx +++ b/packages/core-components/src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx @@ -25,7 +25,7 @@ const useStyles = makeStyles( margin: theme.spacing(2, 0), display: 'grid', gridAutoFlow: 'column', - gridAutoColumns: 'min-content', + gridAutoColumns: 'max-content', gridGap: theme.spacing(3), }, }), From 86436efe91ba4e7c84e0355aaf4e56972fe8c6f1 Mon Sep 17 00:00:00 2001 From: mario ma Date: Wed, 25 Jun 2025 17:13:10 +0800 Subject: [PATCH 2/2] fix: code review Signed-off-by: mario ma --- .../src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/core-components/src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx b/packages/core-components/src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx index 3c46e6ba27..0b8fe8cd8c 100644 --- a/packages/core-components/src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx +++ b/packages/core-components/src/components/HeaderIconLinkRow/HeaderIconLinkRow.tsx @@ -25,8 +25,9 @@ const useStyles = makeStyles( margin: theme.spacing(2, 0), display: 'grid', gridAutoFlow: 'column', - gridAutoColumns: 'max-content', + gridAutoColumns: 'min-content', gridGap: theme.spacing(3), + wordBreak: 'keep-all', }, }), { name: 'BackstageHeaderIconLinkRow' },