diff --git a/.changeset/thirty-kiwis-trade.md b/.changeset/thirty-kiwis-trade.md index 73fc21724b..08ddbaa1a4 100644 --- a/.changeset/thirty-kiwis-trade.md +++ b/.changeset/thirty-kiwis-trade.md @@ -5,13 +5,18 @@ Migrated `EntityAboutCard`, `EntityLinksCard`, `EntityLabelsCard`, `GroupProfileCard`, and `UserProfileCard` from MUI/InfoCard to use the new BUI card layout and BUI components where possible. -**BREAKING**: Removed `variant` prop from EntityAboutCard, EntityUserProfileCard, EntityGroupProfileCard, EntityLabelsCard, EntityLinksCard +**BREAKING**: Removed `variant` prop from EntityAboutCard, EntityUserProfileCard, EntityGroupProfileCard, EntityLabelsCard, EntityLinksCard. Removed `gridSizes` prop from `AboutField`. **Migration:** -Simply delete the obsolete `variant` prop, e.g: +Simply delete the obsolete `variant` and `gridSizes` props, e.g: ```diff - + ``` + +```diff +- ++ +``` diff --git a/plugins/catalog/report.api.md b/plugins/catalog/report.api.md index 411d60076e..48e3f53de2 100644 --- a/plugins/catalog/report.api.md +++ b/plugins/catalog/report.api.md @@ -8,7 +8,6 @@ import { BackstagePlugin } from '@backstage/core-plugin-api'; import { CatalogApi } from '@backstage/plugin-catalog-react'; import { ComponentEntity } from '@backstage/catalog-model'; import { CompoundEntityRef } from '@backstage/catalog-model'; -import { CSSProperties } from 'react'; import { DomainEntity } from '@backstage/catalog-model'; import { ElementType } from 'react'; import { Entity } from '@backstage/catalog-model'; @@ -60,12 +59,8 @@ export interface AboutFieldProps { // (undocumented) className?: string; // (undocumented) - gridSizes?: Record; - // (undocumented) label: string; // (undocumented) - style?: CSSProperties; - // (undocumented) value?: string; } diff --git a/plugins/catalog/src/components/AboutCard/AboutContent.tsx b/plugins/catalog/src/components/AboutCard/AboutContent.tsx index 503d963575..eff9ae7da3 100644 --- a/plugins/catalog/src/components/AboutCard/AboutContent.tsx +++ b/plugins/catalog/src/components/AboutCard/AboutContent.tsx @@ -133,7 +133,6 @@ export function AboutContent(props: AboutContentProps) { label={t('aboutCard.ownerField.label')} value={t('aboutCard.ownerField.value')} className={classes.description} - gridSizes={{ xs: 12, sm: 6, lg: 4 }} > {ownedByRelations.length > 0 && ( @@ -143,7 +142,6 @@ export function AboutContent(props: AboutContentProps) { {partOfDomainRelations.length > 0 && ( {partOfSystemRelations.length > 0 && ( )} {(isAPI || @@ -201,13 +196,11 @@ export function AboutContent(props: AboutContentProps) { )} {(entity?.metadata?.tags || []).map(tag => ( diff --git a/plugins/catalog/src/components/AboutCard/AboutField.tsx b/plugins/catalog/src/components/AboutCard/AboutField.tsx index 36a0406876..725a82612a 100644 --- a/plugins/catalog/src/components/AboutCard/AboutField.tsx +++ b/plugins/catalog/src/components/AboutCard/AboutField.tsx @@ -47,14 +47,13 @@ const useStyles = makeStyles(theme => ({ export interface AboutFieldProps { label: string; value?: string; - gridSizes?: Record; children?: ReactNode; className?: string; } /** @public */ export function AboutField(props: AboutFieldProps) { - const { label, value, gridSizes: _gridSizes, children, className } = props; + const { label, value, children, className } = props; const classes = useStyles(); const { t } = useTranslationRef(catalogTranslationRef); diff --git a/plugins/org/src/components/Cards/User/UserProfileCard/UserProfileCard.tsx b/plugins/org/src/components/Cards/User/UserProfileCard/UserProfileCard.tsx index d35682101e..e34adde670 100644 --- a/plugins/org/src/components/Cards/User/UserProfileCard/UserProfileCard.tsx +++ b/plugins/org/src/components/Cards/User/UserProfileCard/UserProfileCard.tsx @@ -93,9 +93,6 @@ const CardTitle = (props: { title: string; pictureSrc?: string }) => /** @public */ export const UserProfileCard = (props: { - // Accepted for API compatibility but not applied. - // The new entity page layout handles card sizing. - // TODO: Discuss removal in code review. showLinks?: boolean; maxRelations?: number; hideIcons?: boolean;