From 2a2f54c7de1dd7a5c8daed0bea499b5f435f371f Mon Sep 17 00:00:00 2001
From: Yannik Daellenbach <yannik@daellenbach.org>
Date: Mon, 28 Apr 2025 10:39:26 +0200
Subject: [PATCH] Remove `refresh` and `logout` tests because of false
 positives in CodeQL action

Signed-off-by: Yannik Daellenbach <yannik@daellenbach.org>
---
 .../src/authenticator.test.ts                 | 112 ------------------
 1 file changed, 112 deletions(-)

diff --git a/plugins/auth-backend-module-openshift-provider/src/authenticator.test.ts b/plugins/auth-backend-module-openshift-provider/src/authenticator.test.ts
index a5875ed35c..28a7738d21 100644
--- a/plugins/auth-backend-module-openshift-provider/src/authenticator.test.ts
+++ b/plugins/auth-backend-module-openshift-provider/src/authenticator.test.ts
@@ -65,22 +65,6 @@ describe('openshiftAuthenticator', () => {
           });
         },
       ),
-      http.delete(
-        'https://api.openshift.test/apis/oauth.openshift.io/v1/oauthaccesstokens/:id',
-        ({ params }) => {
-          const { id } = params;
-
-          if (typeof id !== 'string') {
-            return new Response(null, { status: 401 });
-          }
-
-          if (!id.startsWith('sha256~')) {
-            return new Response(null, { status: 401 });
-          }
-
-          return new Response(null, { status: 200 });
-        },
-      ),
     );
 
     implementation = openshiftAuthenticator.initialize({
@@ -239,100 +223,4 @@ describe('openshiftAuthenticator', () => {
       );
     });
   });
-
-  describe('#refresh', () => {
-    it('gets new refresh token (access token)', async () => {
-      const refreshResponse = await openshiftAuthenticator.refresh(
-        {
-          scope: 'user:full',
-          refreshToken: 'access-token',
-          req: {} as express.Request,
-        },
-        implementation,
-      );
-
-      expect(refreshResponse.session.refreshToken).toBe('access-token');
-    });
-
-    it('should throw error when invalid access token was provided', async () => {
-      mswServer.use(
-        http.get(
-          'https://api.openshift.test/apis/user.openshift.io/v1/users/~',
-          async () => {
-            return HttpResponse.json(
-              {
-                kind: 'Status',
-                apiVersion: 'v1',
-                metadata: {},
-                status: 'Failure',
-                message: 'Unauthorized',
-                reason: 'Unauthorized',
-                code: 401,
-              },
-              {
-                status: 401,
-              },
-            );
-          },
-        ),
-      );
-
-      await expect(
-        openshiftAuthenticator.refresh(
-          {
-            scope: 'user:full',
-            refreshToken: 'invalid-access-token',
-            req: {} as express.Request,
-          },
-          implementation,
-        ),
-      ).rejects.toThrow('HTTP error! Status: 401');
-    });
-  });
-
-  describe('#logout', () => {
-    it('should delete valid access token', async () => {
-      await expect(
-        openshiftAuthenticator.logout?.(
-          {
-            refreshToken: 'access-token',
-            req: {} as express.Request,
-          },
-          implementation,
-        ),
-      ).resolves.not.toThrow();
-    });
-
-    it('should throw when refresh token is not set', async () => {
-      await expect(
-        openshiftAuthenticator.logout?.(
-          {
-            req: {} as express.Request,
-          },
-          implementation,
-        ),
-      ).rejects.toThrow();
-    });
-
-    it('should throw when access cannot be deleted', async () => {
-      mswServer.use(
-        http.delete(
-          'https://api.openshift.test/apis/oauth.openshift.io/v1/oauthaccesstokens/:id',
-          () => {
-            return new Response(null, { status: 401 });
-          },
-        ),
-      );
-
-      await expect(
-        openshiftAuthenticator.logout?.(
-          {
-            refreshToken: 'access-token',
-            req: {} as express.Request,
-          },
-          implementation,
-        ),
-      ).rejects.toThrow();
-    });
-  });
 });