fix(auth-backend): harden default allowed patterns for CIMD and DCR (#34260)
* fix(auth-backend): harden default allowed patterns for CIMD and DCR Signed-off-by: benjdlambert <ben@blam.sh> * address PR review feedback for OIDC defaults - narrow CLI client ID pattern to exact cli.json path - add BREAKING prefix to changeset - add IPv6 [::1] to docs examples - add loopback redirect URI tests for IPv6 and 127.0.0.1 Signed-off-by: benjdlambert <ben@blam.sh> * remove dead ['*'] fallback when features are disabled The restrictive defaults are now always used regardless of the enabled flag, since the patterns are only consulted on code paths that require the feature to be enabled. Signed-off-by: benjdlambert <ben@blam.sh> * add default pattern tests and fix docs cli example Signed-off-by: benjdlambert <ben@blam.sh> * use URL constructor for CLI client ID Signed-off-by: benjdlambert <ben@blam.sh> * use string templating for cliClientId to match OidcRouter Signed-off-by: benjdlambert <ben@blam.sh> * fix docs: remove misleading CLI client_id URL example Signed-off-by: benjdlambert <ben@blam.sh> --------- Signed-off-by: benjdlambert <ben@blam.sh>
This commit is contained in:
Vendored
+5
-3
@@ -163,7 +163,8 @@ export interface Config {
|
||||
|
||||
/**
|
||||
* A list of allowed URI patterns to use for redirect URIs during
|
||||
* dynamic client registration. Defaults to '[*]' which allows any redirect URI.
|
||||
* dynamic client registration.
|
||||
* Defaults to Cursor and loopback addresses (localhost, 127.0.0.1, [::1]).
|
||||
*/
|
||||
allowedRedirectUriPatterns?: string[];
|
||||
};
|
||||
@@ -183,7 +184,8 @@ export interface Config {
|
||||
/**
|
||||
* A list of allowed URI patterns for client_id URLs.
|
||||
* Uses glob-style pattern matching where `*` matches any characters.
|
||||
* Defaults to ['*'] which allows any client_id URL.
|
||||
* Defaults to `['https://claude.ai/*', 'https://vscode.dev/*', '{baseUrl}/.well-known/oauth-client/cli.json']`
|
||||
* where `{baseUrl}` is the auth backend's base URL.
|
||||
*
|
||||
* @example ['https://example.com/*', 'https://*.trusted-domain.com/*']
|
||||
*/
|
||||
@@ -192,7 +194,7 @@ export interface Config {
|
||||
/**
|
||||
* A list of allowed URI patterns for redirect URIs.
|
||||
* Uses glob-style pattern matching where `*` matches any characters.
|
||||
* Defaults to ['*'] which allows any redirect URI.
|
||||
* Defaults to loopback addresses (localhost, 127.0.0.1, [::1]).
|
||||
*
|
||||
* @example ['http://localhost:*', 'http://127.0.0.1:*\/callback']
|
||||
*/
|
||||
|
||||
Reference in New Issue
Block a user