From 88d4769df5848ef971e88cc618365d9ce8d08eb3 Mon Sep 17 00:00:00 2001 From: sagardesai1 Date: Thu, 4 Apr 2024 14:53:56 -0400 Subject: [PATCH 1/3] Fix: allow unauthenticated requests for entity badges Signed-off-by: sagardesai1 --- .changeset/beige-birds-film.md | 5 +++++ plugins/badges-backend/src/plugin.ts | 4 ++++ 2 files changed, 9 insertions(+) create mode 100644 .changeset/beige-birds-film.md diff --git a/.changeset/beige-birds-film.md b/.changeset/beige-birds-film.md new file mode 100644 index 0000000000..24f756e50f --- /dev/null +++ b/.changeset/beige-birds-film.md @@ -0,0 +1,5 @@ +--- +'@backstage/plugin-badges-backend': minor +--- + +Fix unauthorized requests by allowing unauthenticated requests diff --git a/plugins/badges-backend/src/plugin.ts b/plugins/badges-backend/src/plugin.ts index be965ae4a6..e42ff0aa41 100644 --- a/plugins/badges-backend/src/plugin.ts +++ b/plugins/badges-backend/src/plugin.ts @@ -63,6 +63,10 @@ export const badgesPlugin = createBackendPlugin({ auth, }), ); + httpRouter.addAuthPolicy({ + path: '/', + allow: 'unauthenticated', + }); }, }); }, From 158becaca16facb7ba864bf49c519047756fca63 Mon Sep 17 00:00:00 2001 From: sagardesai1 Date: Thu, 4 Apr 2024 15:42:52 -0400 Subject: [PATCH 2/3] grammar fix Signed-off-by: sagardesai1 --- .changeset/beige-birds-film.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.changeset/beige-birds-film.md b/.changeset/beige-birds-film.md index 24f756e50f..88b1005566 100644 --- a/.changeset/beige-birds-film.md +++ b/.changeset/beige-birds-film.md @@ -2,4 +2,4 @@ '@backstage/plugin-badges-backend': minor --- -Fix unauthorized requests by allowing unauthenticated requests +Fix unauthorized requests by allowing unauthenticated requests. From 2af555b7ab834161e037f86313beaf199e76077e Mon Sep 17 00:00:00 2001 From: sagardesai1 Date: Tue, 9 Apr 2024 07:04:05 -0400 Subject: [PATCH 3/3] updating path Signed-off-by: sagardesai1 --- plugins/badges-backend/src/plugin.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/plugins/badges-backend/src/plugin.ts b/plugins/badges-backend/src/plugin.ts index e42ff0aa41..53e03f21e5 100644 --- a/plugins/badges-backend/src/plugin.ts +++ b/plugins/badges-backend/src/plugin.ts @@ -64,7 +64,11 @@ export const badgesPlugin = createBackendPlugin({ }), ); httpRouter.addAuthPolicy({ - path: '/', + path: '/entity/:entityUuid/:badgeId', + allow: 'unauthenticated', + }); + httpRouter.addAuthPolicy({ + path: '/entity/:namespace/:kind/:name/badge/:badgeId', allow: 'unauthenticated', }); },