Api refactor, return object for updateRelease
Signed-off-by: Erik Engervall <erik.engervall@gmail.com>
This commit is contained in:
@@ -438,9 +438,11 @@ export class GitReleaseApiClient implements GitReleaseApi {
|
||||
});
|
||||
|
||||
return {
|
||||
name: updatedRelease.name,
|
||||
tagName: updatedRelease.tag_name,
|
||||
htmlUrl: updatedRelease.html_url,
|
||||
release: {
|
||||
name: updatedRelease.name,
|
||||
tagName: updatedRelease.tag_name,
|
||||
htmlUrl: updatedRelease.html_url,
|
||||
},
|
||||
};
|
||||
};
|
||||
|
||||
@@ -714,9 +716,11 @@ export interface GitReleaseApi {
|
||||
prerelease?: boolean;
|
||||
} & OwnerRepo,
|
||||
) => Promise<{
|
||||
name: string | null;
|
||||
tagName: string;
|
||||
htmlUrl: string;
|
||||
release: {
|
||||
name: string | null;
|
||||
tagName: string;
|
||||
htmlUrl: string;
|
||||
};
|
||||
}>;
|
||||
|
||||
/**
|
||||
|
||||
@@ -301,7 +301,7 @@ export function usePatch({
|
||||
|
||||
const selectedPatchCommit = releaseBranchRes.value.selectedPatchCommit;
|
||||
|
||||
const updatedRelease = await pluginApiClient
|
||||
const { release } = await pluginApiClient
|
||||
.updateRelease({
|
||||
owner: project.owner,
|
||||
repo: project.repo,
|
||||
@@ -316,13 +316,13 @@ ${selectedPatchCommit.commit.message}`,
|
||||
.catch(asyncCatcher);
|
||||
|
||||
addStepToResponseSteps({
|
||||
message: `Updated release "${updatedRelease.name}"`,
|
||||
secondaryMessage: `with tag ${updatedRelease.tagName}`,
|
||||
link: updatedRelease.htmlUrl,
|
||||
message: `Updated release "${release.name}"`,
|
||||
secondaryMessage: `with tag ${release.tagName}`,
|
||||
link: release.htmlUrl,
|
||||
});
|
||||
|
||||
return {
|
||||
...updatedRelease,
|
||||
...release,
|
||||
};
|
||||
}, [createdReferenceRes.value, createdReferenceRes.error]);
|
||||
|
||||
|
||||
@@ -140,7 +140,7 @@ export function usePromoteRc({
|
||||
abortIfError(createRcRes.error);
|
||||
if (!createRcRes.value) return undefined;
|
||||
|
||||
const promotedRelease = await pluginApiClient
|
||||
const { release } = await pluginApiClient
|
||||
.updateRelease({
|
||||
owner: project.owner,
|
||||
repo: project.repo,
|
||||
@@ -151,13 +151,13 @@ export function usePromoteRc({
|
||||
.catch(asyncCatcher);
|
||||
|
||||
addStepToResponseSteps({
|
||||
message: `Promoted "${promotedRelease.name}"`,
|
||||
secondaryMessage: `from "${rcRelease.tagName}" to "${promotedRelease.tagName}"`,
|
||||
link: promotedRelease.htmlUrl,
|
||||
message: `Promoted "${release.name}"`,
|
||||
secondaryMessage: `from "${rcRelease.tagName}" to "${release.tagName}"`,
|
||||
link: release.htmlUrl,
|
||||
});
|
||||
|
||||
return {
|
||||
...promotedRelease,
|
||||
...release,
|
||||
};
|
||||
}, [createRcRes.value, createRcRes.error]);
|
||||
|
||||
|
||||
@@ -286,9 +286,11 @@ export const mockApiClient: GitReleaseApi = {
|
||||
})),
|
||||
|
||||
updateRelease: jest.fn(async () => ({
|
||||
name: 'mock_update_release_name',
|
||||
tagName: 'mock_update_release_tag_name',
|
||||
htmlUrl: 'mock_update_release_html_url',
|
||||
release: {
|
||||
name: 'mock_update_release_name',
|
||||
tagName: 'mock_update_release_tag_name',
|
||||
htmlUrl: 'mock_update_release_html_url',
|
||||
},
|
||||
})),
|
||||
|
||||
getAllTags: jest.fn(async () => [
|
||||
|
||||
Reference in New Issue
Block a user